Manage disabled autoscaling for PopupHelper

If the disable autoscaling flag is set, e.g. tooltips would be scaled
to 100%. This commit scales and renders the Shell uses for PopupHelper
according to the monitor zoom the Shell is assigned to.

Author: akoch-yatta

org.eclipse.draw2d/src/org/eclipse/draw2d/FigureUtilities.java

@@ -77,6 +77,7 @@ protected static GC getGC() {
 			Shell shell = new Shell();
 			InternalDraw2dUtils.configureForAutoscalingMode(shell);
 			gc = new GC(shell);
+			gc.setAdvanced(true);
 			appliedFont = gc.getFont();
 		}
 		return gc;

org.eclipse.draw2d/src/org/eclipse/draw2d/PopUpHelper.java

@@ -15,10 +15,12 @@
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.Rectangle;
+import org.eclipse.swt.widgets.Canvas;
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Shell;
 
 import org.eclipse.draw2d.geometry.Dimension;
+import org.eclipse.draw2d.internal.InternalDraw2dUtils;
 
 /**
  * Provides abstract support for classes that manage popups. Popups in Draw2d
@@ -62,7 +64,7 @@ protected PopUpHelper(Control c) {
 	 */
 	protected PopUpHelper(Control c, int shellStyle) {
 		control = c;
-		this.shellStyle = shellStyle | SWT.NO_BACKGROUND | SWT.NO_REDRAW_RESIZE;
+		this.shellStyle = shellStyle | SWT.NO_BACKGROUND | SWT.NO_REDRAW_RESIZE | SWT.DOUBLE_BUFFERED;
 	}
 
 	/**
@@ -72,9 +74,8 @@ protected PopUpHelper(Control c, int shellStyle) {
 	 * @return the newly created LightweightSystem
 	 * @since 2.0
 	 */
-	@SuppressWarnings("static-method")
 	protected LightweightSystem createLightweightSystem() {
-		return new LightweightSystem();
+		return InternalDraw2dUtils.disableAutoscale ? new PopupHelperLightweightSystem() : new LightweightSystem();
 	}
 
 	/**
@@ -219,4 +220,62 @@ protected void show() {
 		tipShowing = true;
 	}
 
+	private class PopupHelperLightweightSystem extends LightweightSystem {
+
+		/**
+		 * Data that can be set to scale this widget at 100%.
+		 */
+		private static final String DATA_AUTOSCALE_DISABLED = "AUTOSCALE_DISABLED"; //$NON-NLS-1$
+
+		/**
+		 * Returns the zoom of the monitor this widget is assigned to.
+		 *
+		 * @return 1.0 at 100%, 1.25 at 125% etc.
+		 */
+		private static double getMonitorZoomScale(Control c) {
+				return c.getMonitor().getZoom() / 100.0;
+		}
+
+		/**
+		 * The scalable pane that is injected between the root figure and the contents
+		 * of this viewport.
+		 */
+		private final ScalableLayeredPane scalablePane;
+
+		private PopupHelperLightweightSystem() {
+			scalablePane = new ScalableLayeredPane(false);
+			scalablePane.setLayoutManager(new StackLayout());
+			getRootFigure().add(scalablePane);
+		}
+
+		/**
+		 * Updates the scale factor of the scalable pane to the given value.
+		 *
+		 * @param scale The new scale factor.
+		 */
+		private void setScale(double scale) {
+			scalablePane.setScale(scale);
+		}
+
+		@Override
+		public void setControl(Canvas c) {
+			if (c == null) {
+				return;
+			}
+
+			c.setData(DATA_AUTOSCALE_DISABLED, true);
+			c.addListener(SWT.ZoomChanged, e -> setScale(e.detail / 100.0));
+			setScale(getMonitorZoomScale(c));
+
+			super.setControl(c);
+		}
+
+		@Override
+		public void setContents(IFigure figure) {
+			scalablePane.removeAll();
+			if (figure != null) {
+				scalablePane.add(figure);
+			}
+		}
+	}
 }

org.eclipse.draw2d/src/org/eclipse/draw2d/ToolTipHelper.java

@@ -121,7 +121,7 @@ public void displayToolTipNear(IFigure hoverSource, IFigure tip, int eventX, int
 			Point displayPoint = computeWindowLocation(tip, eventX, eventY);
 			Dimension shellSize = getLightweightSystem().getRootFigure().getPreferredSize()
 					.getExpanded(getShellTrimSize());
-			setShellBounds(displayPoint.x, displayPoint.y, shellSize.width, shellSize.height);
+			setShellBounds(displayPoint.x, displayPoint.y, shellSize.width + 1, shellSize.height + 1);
 			show();
 			// Moving an invisible shell might not be supported by the operating system. Try
 			// again once it has become visible...

org.eclipse.gef/src/org/eclipse/gef/internal/ui/palette/editparts/EditPartTipHelper.java

@@ -76,7 +76,7 @@ public void displayToolTipAt(IFigure tip, int tipPosX, int tipPosY) {
 			// Display the tip
 			EditPartTipHelper.setHelper(this);
 			getLightweightSystem().setContents(tip);
-			setShellBounds(tipPosX, tipPosY, tipSize.width, tipSize.height);
+			setShellBounds(tipPosX, tipPosY, tipSize.width + 1, tipSize.height + 1);
 			show();
 			getShell().setCapture(true);
 		}