Use DrawableTextUtilities for Label and TextFlow figures #817
Conversation
| /** | ||
| * @since 3.21 | ||
| */ | ||
| public static TextUtilities getTextUtilities(IFigure figure) { | ||
| if (getRoot(figure) instanceof LightweightSystem.RootFigure rootFigure) { | ||
| return rootFigure.getTextUtilities(); | ||
| } | ||
| return TextUtilities.INSTANCE; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm still not sure where to put this. In principle, it might also be directly added to the IFigure?
There was a problem hiding this comment.
I think I figure sounds like a very good place for this. Should we also move the getRoot there? Or better add?
There was a problem hiding this comment.
Should we also move the getRoot there? Or better add?
I think that makes sense. The way it is currently done is by using something like, for e.g. the font and colors:
public Object xyz() {
if (getParent() != null) {
return getParent().xyz();
}
return null;
}So that I'd do as a separate PR, together with cleaning up all of the other methods.
There was a problem hiding this comment.
In hindsight, I don't think the getRoot() method is a good idea. In principle, any parent can override the getTextUtilities() method and provide its own implementation. This is how it's done for all other methods that are overridden by the root figure.
Changing this here feels odd. There are also several figures that access TextUtilities.INSTANCE or the static FigureUtilities methods directly. This I'd address with a separate PR.
ptziegler
force-pushed
the
figure-utilities
branch
from
a750f57 to
5d4b806
Compare
| return TextUtilities.INSTANCE; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Weirdly enough, increasing the visibility doesn't break binary compatibility, but may cause source-incompatibilities if overridden by subclasses.
This adds a new getTextUtilities() method to the IFigure interface. The method is overriden by the RootFigure and returns an object of type DrawableTextUtilities, which is created for the canvas hooked to the LWS. When using this method, users are guaranteed that the font sizes returned calculated by this instance match the zoom level of the monitor they are painted on.
ptziegler
force-pushed
the
figure-utilities
branch
from
5d4b806 to
7725641
Compare
|
I also just noticed that the fix for #816 is not applied to the |
2 participants
This adds a new getTextUtilities() method to the IFigure interface. The method is overriden by the RootFigure and returns an object of type DrawableTextUtilities, which is created for the canvas hooked to the LWS.
When using this method, users are guaranteed that the font sizes returned calculated by this instance match the zoom level of the monitor they are painted on.