Create custom cursor for 100%, 150% and 200% zoom #872 #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
should this go into 3.26? or better 3.27.0.M1 |
Contributor
Author
|
It's only a visual problem that doesn't affect usability. I'm also running some tests right now, so I think it's better suited for the next release. |
At least on Windows and Linux, the operating system doesn't seem to linearly scale the system cursor. Instead, predefined cursor images are used for: - ( ..., 150%) - Cursor at 100% monitor zoom - [150%, 200%) - Cursor at 150% monitor zoom - (200%, ...) - Cursor at 200% monitor zoom SWT is linearly scaling the cursor icon. So if at e.g. 125% zoom, the cursor inside the widget will be scaled to 125% zoom but is not scaled outside the widget. To account for this, the SWT-based cursor is replaced with three cursor SVGs, one for each of those zoom levels. Note that the images are split up to make sure the line width is exactly one for each cursor. Closes eclipse-gef#872
Contributor
Author
|
The custom cursors now hopefully follow the same scaling logic as the native Windows cursors. I'm only able to test it up to 200% zoom, but I'm fairly certain the same cursor is used for higher monitor zooms as well. I still want to try out different ways to decrease anti-aliasing for the SVG because for cursors, crips edges definitely work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on Windows and Linux, the operating system doesn't seem to linearly scale the system cursor.
Instead, predefined cursor images are used for:
SWT is linearly scaling the cursor icon. So if at e.g. 125% zoom, the cursor inside the widget will be scaled to 125% zoom but is not scaled outside the widget.
To account for this, the SWT-based cursor is replaced with three cursor SVGs, one for each of those zoom levels. Note that the images are split up to make sure the line width is exactly one for each cursor.
Closes #872