Skip to content

Commit 09dcabd

Browse files
authored
Remove important from accessibility css (#412)
1 parent 2d240a3 commit 09dcabd

File tree

8 files changed

+63
-36
lines changed

8 files changed

+63
-36
lines changed

examples/workflow-glsp/css/diagram.css

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,33 +72,33 @@
7272
stroke-width: 1;
7373
}
7474

75-
.sprotty-edge.weighted.low:not(.selected),
76-
.sprotty-edge.weighted.low:not(.selected) .arrow {
75+
.sprotty-edge.weighted.low:not(.selected, .navigable-element),
76+
.sprotty-edge.weighted.low:not(.selected, .navigable-element) .arrow {
7777
stroke: rgb(128, 90, 233);
7878
}
7979

80-
.sprotty-edge.weighted.low:not(.selected) .arrow {
80+
.sprotty-edge.weighted.low:not(.selected, .navigable-element) .arrow {
8181
fill: rgb(128, 90, 233);
8282
}
8383

84-
.sprotty-edge.weighted:not(.selected),
85-
.sprotty-edge.weighted:not(.selected) .arrow,
86-
.sprotty-edge.weighted.medium:not(.selected),
87-
.sprotty-edge.weighted.medium:not(.selected) .arrow {
84+
.sprotty-edge.weighted:not(.selected, .navigable-element),
85+
.sprotty-edge.weighted:not(.selected, .navigable-element) .arrow,
86+
.sprotty-edge.weighted.medium:not(.selected, .navigable-element),
87+
.sprotty-edge.weighted.medium:not(.selected, .navigable-element) .arrow {
8888
stroke: rgb(98, 60, 193);
8989
}
9090

91-
.sprotty-edge.weighted:not(.selected) .arrow,
92-
.sprotty-edge.weighted.medium:not(.selected) .arrow {
91+
.sprotty-edge.weighted:not(.selected, .navigable-element) .arrow,
92+
.sprotty-edge.weighted.medium:not(.selected, .navigable-element) .arrow {
9393
fill: rgb(98, 60, 193);
9494
}
9595

96-
.sprotty-edge.weighted.high:not(.selected),
97-
.sprotty-edge.weighted.high:not(.selected) .arrow {
96+
.sprotty-edge.weighted.high:not(.selected, .navigable-element),
97+
.sprotty-edge.weighted.high:not(.selected, .navigable-element) .arrow {
9898
stroke: rgb(68, 30, 163);
9999
}
100100

101-
.sprotty-edge.weighted.high:not(.selected) .arrow {
101+
.sprotty-edge.weighted.high:not(.selected, .navigable-element) .arrow {
102102
fill: rgb(68, 30, 163);
103103
}
104104

examples/workflow-standalone/css/diagram.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
stroke: rgb(0, 0, 0);
2828
}
2929

30-
.sprotty-edge {
30+
.sprotty-edge:not(.navigable-element) {
3131
stroke: black;
3232
}
3333

packages/client/css/glsp-sprotty.css

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -318,21 +318,6 @@
318318
fill: transparent;
319319
}
320320

321-
.search-hidden {
322-
opacity: 0.4;
323-
}
324-
325-
.search-highlighted .sprotty-node,
326-
.search-highlighted .sprotty-edge {
327-
stroke-width: 1.5px;
328-
stroke-width: 2px;
329-
stroke-dashoffset: 5;
330-
stroke-dasharray: 5, 5;
331-
stroke-linecap: round;
332-
stroke: rgb(218, 89, 15) !important;
333-
stroke: #130bf7 !important;
334-
}
335-
336321
.ui-extension.hidden {
337322
display: none;
338323
opacity: 0;

packages/client/css/keyboard.css

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,18 @@
2424
grid-template-columns: auto auto auto;
2525
}
2626

27+
.grid-container.grid-visible {
28+
opacity: 0.7;
29+
visibility: visible;
30+
}
31+
32+
.grid-container.grid-hidden {
33+
opacity: 0;
34+
visibility: hidden;
35+
}
36+
2737
.grid-container:focus {
28-
opacity: 1 !important;
38+
opacity: 1;
2939
}
3040

3141
.grid-item {

packages/client/css/navigation.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@
1717
:root {
1818
--glsp-navigation-highlight: rgba(136, 68, 68, 0.2);
1919
}
20+
2021
.navigable-element {
21-
stroke: var(--glsp-navigation-highlight) !important;
22+
stroke: var(--glsp-navigation-highlight);
2223
}
24+
2325
.navigable-element .sprotty-edge.arrow {
24-
fill: var(--glsp-navigation-highlight) !important;
25-
stroke: var(--glsp-navigation-highlight) !important;
26+
fill: var(--glsp-navigation-highlight);
27+
stroke: var(--glsp-navigation-highlight);
2628
}

packages/client/css/search.css

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
/********************************************************************************
2+
* Copyright (c) 2023-2025 Business Informatics Group (TU Wien) and others.
3+
*
4+
* This program and the accompanying materials are made available under the
5+
* terms of the Eclipse Public License v. 2.0 which is available at
6+
* http://www.eclipse.org/legal/epl-2.0.
7+
*
8+
* This Source Code may also be made available under the following Secondary
9+
* Licenses when the conditions for such availability set forth in the Eclipse
10+
* Public License v. 2.0 are satisfied: GNU General Public License, version 2
11+
* with the GNU Classpath Exception which is available at
12+
* https://www.gnu.org/software/classpath/license.html.
13+
*
14+
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
15+
********************************************************************************/
16+
17+
.search-hidden {
18+
opacity: 0.4;
19+
}
20+
21+
.search-highlighted .sprotty-node,
22+
.search-highlighted .sprotty-edge {
23+
stroke-width: 1.5px;
24+
stroke-width: 2px;
25+
stroke-dashoffset: 5;
26+
stroke-dasharray: 5, 5;
27+
stroke-linecap: round;
28+
stroke: #130bf7;
29+
}

packages/client/src/features/accessibility/keyboard-grid/keyboard-grid.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ export class KeyboardGrid extends GLSPAbstractUIExtension implements IActionHand
9797
protected override setContainerVisible(visible: boolean): void {
9898
if (this.containerElement) {
9999
if (visible) {
100-
this.containerElement.style.visibility = 'visible';
101-
this.containerElement.style.opacity = '0.7';
100+
this.containerElement.classList.remove('grid-hidden');
101+
this.containerElement.classList.add('grid-visible');
102102
} else {
103-
this.containerElement.style.visibility = 'hidden';
104-
this.containerElement.style.opacity = '0';
103+
this.containerElement.classList.remove('grid-visible');
104+
this.containerElement.classList.add('grid-hidden');
105105
}
106106
}
107107
}

packages/client/src/features/accessibility/search/search-palette-module.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
********************************************************************************/
1616

1717
import { bindAsService, BindingContext, FeatureModule, TYPES } from '@eclipse-glsp/sprotty';
18+
import '../../../../css/search.css';
1819
import { SearchAutocompletePalette } from './search-palette';
1920
import { SearchAutocompletePaletteTool } from './search-tool';
2021

0 commit comments

Comments
 (0)