Move Diagram Menu To View's submenu

[wss29]

Hi,
I do not want to Diagram menu at the top, I want to move the top diagram menu to the submenu of view menu item, Is any method that can implement this?

[martin-fleck-at]

@wss29 Hi, the menu is created by the GLSPDiagramMenuContribution (see https://github.com/search?q=repo%3Aeclipse-glsp%2Fglsp-theia-integration%20GLSPDiagramMenuContribution&type=code). You can rebind that and simply register the menu action items against CommonMenus.VIEW (from @theia/core/lib/browser) instead of GLSPDiagramMenus.DIAGRAM. For more details on contributing menu items, you can have a look at the Theia documentation: https://theia-ide.org/docs/commands_keybindings/#contributing-menu-items.

I think that should yield the result you want.

[wss29]

Hi,
Do your mean I should re-register every menu action item under GLSPDiagramMenus.DIAGRAM to CommonMenus.VIEW one by one, not direct move GLSPDiagramMenus.DIAGRAM to be one submenu of CommonMenus.VIEW?

[martin-fleck-at]

There are definitely several approaches to this. So feel free to move the diagram menu using a custom menu contribution, of course. I think whatever is easier for you and fits to the MenuModelRegistry API.

[wss29]

Hi,
I used glsp last release version 1.0.0, that version does not have GLSPDiagramMenuContribution , just DiagramMenuContribution

I rebind to my new VDMDiagramMenuContribution, but get the error.



Could DiagramMenuContribution be rebind in the last release version 1.0.0? or what kind of version can I use to implement my rebind. I do not know how long the new version glsp will release.

[tortmayr]

Hi @wss29,
in the 1.0.0 Version the DiagramMenu is provided by "sprotty-theia" and unfortunatley it is configured in a way that does not allow easy rebinding. What you could do is use Theia's FilterContribution API to filter out the unwanted diagram menu and then simply bind your VDMDiagramMenuContribution:

@injectable()
export class DiagramMenuFilterContribution implements FilterContribution {
    registerContributionFilters(registry: ContributionFilterRegistry): void {
        registry.addFilters([MenuContribution], [contribution => !(contribution instanceof DiagramMenuContribution)]);
    }
}
// in your frontend module
export class VDMTheiaFrontendModule extends GLSPTheiaFrontendModule {
      override configure(context: ContainerContext): void {
        super.configure(context);
        context.bind(FilterContribution).to(DiagramMenuFilterContribution);
        context.bind(MenuContribution).to(VDMDiagramMenuFilterContribution);
    }
}

[wss29]

Hi
thanks for your reply. I'm looking forward to the new release version. could it be released on July 2023? If not I will consider downloading RC version

[wss29]

Hi,
I follow these steps and success, but there is a gap in the menu bar after filtering Diagram menu,

[wss29]

Hi,
when I filter GLSPLayoutMenuContribution, the gap disappears. is it because GLSPLayoutMenuContribution has items in Diagram menu?

[tortmayr]

Ah yes, that seems to be the problem. Filtering the LayoutMenuContribution definitely solves the problem. Alternatively, if you want to move the layout entries to your new submenu you can also override the configureDiagramLayoutCommands method in your frontend module and bind a custom menu contribution:

export class VDMTheiaFrontendModule extends GLSPTheiaFrontendModule {
 override configureDiagramLayoutCommands(context: ContainerContext): void {
        context.bind(CommandContribution).to(GLSPLayoutCommandContribution).inSingletonScope();
        context.bind(KeybindingContribution).to(GLSPLayoutKeybindingContribution).inSingletonScope();
        context.bind(MenuContribution).to(YourMenuContribution).inSingletonScope();

    }
 }