ChangeRoutingPointsOperation Handler not updating the notation source model

[xXNicksdaXx]

I have implemented a custom EMFOperationHandler to handle adding / removing routing points of the GEdgeView. While debugging, the handler gets activated correctly and gets the correct input data. The commands created seem to be executable as well. This is reflected in the GModelFactory directly afterwards as well, where the bendpoints are getting retrieved correctly. The problem is that the source model *.notation file is not getting updated to include the bendPoints that were added / removed. When I add a hardcoded bendPoint in the notation source model, it gets rendered but as soon as I move the edge, the bendPoints gets forgotton and not replaced with the correct position, resetting to zero bendPoints again. What is the error here?

public class CromChangeRoutingPointsOperationHandler extends EMFOperationHandler<ChangeRoutingPointsOperation> {
    @Inject
    protected EMFNotationModelState modelState;

    @Override
    public Optional<Command> createCommand(ChangeRoutingPointsOperation operation) {
        EditingDomain editingDomain = modelState.getEditingDomain();

        CompoundCommand compoundCommand = new CompoundCommand();
        for (ElementAndRoutingPoints element : operation.getNewRoutingPoints()) {
            modelState.getIndex().getNotation(element.getElementId(), Edge.class)
                    .map(edge -> updateEdge(editingDomain, edge, element))
                    .ifPresent(commands -> commands.forEach(compoundCommand::append));
        }

        return compoundCommand.getCommandList().isEmpty() ? Optional.empty() : Optional.of(compoundCommand);
    }

    protected List<Command> updateEdge(final EditingDomain editingDomain, final Edge edge,
                                       final ElementAndRoutingPoints elementAndRoutingPoints) {
        List<Command> commands = new ArrayList<>();

        // Clear existing bend points
        if (!edge.getBendPoints().isEmpty()) {
            Command removeBendPointsCommand = RemoveCommand.create(editingDomain, edge,
                    NotationPackage.Literals.EDGE__BEND_POINTS, EcoreUtil.copyAll(edge.getBendPoints()));
            commands.add(removeBendPointsCommand);
        }

        // Add new bend points
        for (GPoint routingPoint : elementAndRoutingPoints.getNewRoutingPoints()) {
            Command addBendPointCommand = AddCommand.create(editingDomain, edge,
                    NotationPackage.Literals.EDGE__BEND_POINTS, EcoreUtil.copy(routingPoint));
            commands.add(addBendPointCommand);
        }
        return commands;
    }
}

Thank you so much for your support!

[tortmayr]

Hi @xXNicksdaXx,

at first glance your implementation looks correct and should work.

This is reflected in the GModelFactory directly afterwards as well, where the bendpoints are getting retrieved correctly

So this means that at the time of the GModel computation the bendpoints are infact correctly placed in the source notation model. Otherwise the GModelFactory would already be incorrect.

Maybe some other operation is interferes here and resets the bendpoints afterwards?

[xXNicksdaXx]

Thank you for your answer. It was not another operation that reset the bendpoints, but it was a method call inside the custom GModelFactory that reset the array. Your answer pointed me to the resolution anyway, searching for the exact moment when the bendPoints were reset, after knowing that it wasn't the source models fault. Thanks a lot!