Selected item moves to the bottom of a compartment

[xXNicksdaXx]

I need help with understanding the following behaviour: I have a tree structure like the following: GNode has a GCompartment for attributes of a class. For each attribute, there is another GCompartment with some GLabels inside. When I select a single attribute, it for some reason I cannot explain moves to the bottom of the list of attributes. This is not reflected in the semantic / notation model, as is visible after reloading the model. This behaviour happens for elements that are resizeable, but not for the ones that do not allow it. Please note that the GCompartment for a single attribute is not moveable per the configuration. I very much appreciate your help here, thanks!

If you need more information, please let me know.

[martin-fleck-at]

@xXNicksdaXx That is very curious indeed! I Just had a look at the code and I have a feeling that this has to do with the BringToFront action that is sent on selection. This action is handled by moving the selected element as a first child of its parent which is reasonable in a free-form layout as SVG renders elements as defined by order but it does not make much sense in a parent where you use a vbox or hbox layout where the order actually also changes the position of the element. The reason is only happens for resizable elements is probably because that triggers a re-layout whereas otherwise that does not happen so the actual change in the element order is not reflected in the rendering.

I think you could try to rebind the BringToFrontCommand and adapt the bringToFront method so that it only changes the order within the parent if the parent is actually using a freeform layout. Overall, that is something that we should also consider in the framework, do you mind opening an issue for that.

[xXNicksdaXx]

Thanks a lot, this was the issue! The solution for my implementation was quite easy because I use a different type for the freeform layout than for the vbox / hbox layout. I'll leave the solution below as well:

export class CromBringToFrontCommand extends BringToFrontCommand {
    protected override bringToFront(selection: ZOrderElement): void {
        const element = selection.element;

        if (element.parent.type === CromModelTypes.STRUCTURED_COMPARTMENT) {
            const childrenLength = element.parent.children.length;
            element.parent.move(element, childrenLength - 1);
        }
    }
}

I also raised an issue for the problem.
Thanks again!