VS Code waits for something when closing

[georghinkel]

Visual Studio Code currently hangs for me when closing it. The message I get is that it is waiting for unsaved changes.

Upon save, the GLSP client sends a saveModel action to the server and the server reacts with setting the dirty state (setDirtyState). But it seems to me that the client also waits for something else. What could it be waiting for?

[tortmayr]

Hi @georghinkel,

The client should only wait for the the SetDirtyStateAction. Nothing more is involved.
Here is a short summary of the save flow

• Upon saving the GLSPVSCodeConnector creates a Promise that resolves once the onDocumentSaved event is fired,
  and then sends the SaveModelAction
• The server handles the SaveModelAction and then responds with a SetDirtyStateAction
• When the client receives a SetDirtyStateAction that was caused from a save action it will fire the onDocumentSaved event
  => the initial save promise should resolve and saving should be completed

If that does not work for you, I suspect that for some reason the server never responds with a proper SetDirtyStateAction.
I tried to reproduce our issue with the workflow-example but for me saving on close always works as expected.

[georghinkel]

Hm, the server logs tell me that the GLSP action was sent:

{"jsonrpc":"2.0","method":"process","params":[{"clientId":"client_0","action":{"kind":"setDirtyState","isDirty":false,"reason":"operation"}}]}

What should be the content of the reason to connect it with the SaveModelAction?