Own Action for Ecore-Creation

[glsp-bot]

I am currently working on Issue#35 (Creation of Ecore-Files). My current task is to create the header for the ecore file with a package (which includes the parameters of the user). Now my question is, if this should happen in a newly created Action on the GLSP Server (for better maintenance) or if a simple hard-coded string, added to the file, in the frontend, would be enough?

Thanks in advance,
Simon

original thread by simongraband

[tortmayr]

That's a good question. First we'd have to establish who handles the ecore file generation. I see two scenarios for this:
a) Wizard is client-only: This means the inital ecore file generation (including adding user parameters) is done in the frontend/client. Once the file is created it's then simply open with the GLSP diagram editor. In this csae simple hard-coded strings added to the file are enough.
b) File generation is executed on server-side: This would mean that all necessary parameters (like packag ename etc.) have to be passed with the inital RequestModelAction. The EcoreModelFactory then checks if the ecore file already exists. If not a new file (based on the parameters) is created. This would probably require some tweaking on client-side of base GLSP.

Maybe you should raise this quesion in ecore-glsp to see which options is preferred by the project leads.

[glsp-bot]

[simongraband]

I talked to Jonas and he told me to create a Java Extension that creates the Ecore-File. This is done so we can later on add the Code Generation Extension in the same way.

[tortmayr]

Sounds good to me. So probably this should be handled with a newly created Action. (GenerateCodeAction or something like that)

[glsp-bot]

[simongraband]

One final question: I know where to place the .jar file of my Java-Code (thanks to the Coffee-Editor) but Jonas thought it would be useful to upload the Java Code aswell. Do you have any recommendation on where i can integrate that into the project?

[tortmayr]

Sorry, I’m afraid I could not understand your question, could you please elaborate a bit more?

[glsp-bot]

[simongraband]

I created a Java-Program, that generates the Ecore-File from the EMF API. I created a JAR-File, from that program, and moved only the jar to the ecore-glsp project. This jar is then called when a new Ecore file is created. Now my question would be where i should place the original java-program (so the Project with the code and the maven dependencies) in the ecore-glsp repository. So that the Code is also in the repository and not only the JAR-File.

[tortmayr]

Ah I see. The java code for ecore-glsp should be checked in the 'server' directory (https://github.com/eclipsesource/ecore-glsp/tree/master/server). Is your java-programm independent of the existing glsp-ecore maven project? If not I'd recommend to integrate it into the existing maven project. Otherwise you could create a parent pom and and add the glsp-ecore project and your new java-programm as submodules. (If you need a reference for this parent-child setup you can checkout https://github.com/eclipsesource/ecore-glsp/blob/master/server/pom.xml)