Nodes are not visualized in Theia #667

hsd-dev · 2022-05-30T15:32:53Z

hsd-dev
May 30, 2022

Sorry for spamming the discussion thread. Now I am trying to setup the application with my own Ecore meta-model. Looks like the nodes are created successfully and GModel is also getting updated accordingly.
Below is the model which started from empty but now has 4 links:

<?xml version="1.0" encoding="UTF-8"?>
<model:Links xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:model="http://www.ipa.fraunhofer.de/model" name="test">
  <body>
    <link resolved="NewLink0"/>
    <link resolved="NewLink1"/>
    <link resolved="NewLink2"/>
    <link resolved="NewLink3"/>
  </body>
</model:Links>

and the notation model:

<?xml version="1.0" encoding="ASCII"?>
<notation:Diagram xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:notation="http://www.eclipse.org/glsp/notation">
  <semanticElement elementId="root"/>
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="NewLink0"/>
    <position x="338.0" y="226.0"/>
    <size width="60.0" height="25.0"/>
  </elements>
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="NewLink1"/>
    <position x="591.0" y="248.0"/>
    <size width="60.0" height="25.0"/>
  </elements>
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="NewLink2"/>
    <position x="550.0" y="421.0"/>
    <size width="60.0" height="25.0"/>
  </elements>
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="NewLink3"/>
    <position x="266.0" y="149.0"/>
    <size width="60.0" height="25.0"/>
  </elements>
</notation:Diagram>

But I don't see the nodes in the editor. What else is needed to visualize it? Note that my model does not have an id element.

The code for CreateLinkNodeHandler

  Link newLink = createLink();
  Command linkCommand = AddCommand.create(editingDomain, model.getBody(), ModelPackage.Literals.BODY__LINK, newLink);

  Shape shape = createShape(newLink.getResolved(), relativeLocation);
  Command shapeCommand = AddCommand.create(editingDomain, diagram, NotationPackage.Literals.DIAGRAM__ELEMENTS, shape);

  CompoundCommand compoundCommand = new CompoundCommand();
  compoundCommand.append(taskCommand);
  compoundCommand.append(shapeCommand);
  return compoundCommand;

Answered by ndoschek

Jun 1, 2022

Hi @ipa-hsd!

Basically, the logic link between the semantic and the notation element is the SemanticElementReference.
To retrieve the notation information this reference is used to retrieve the position/size information.

In our java-emf-theia example, an id is used as element reference, in the following example the id 61bcc27a-3e93-4847-89e4-1d2433371b4b:

Semantic model example.tasklist:

...
  <tasks id="61bcc27a-3e93-4847-89e4-1d2433371b4b" name="NewTask0"/>
...

Notation model example.notation:

...
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="61bcc27a-3e93-4847-89e4-1d2433371b4b"/>
    <position x="382.0" y="101.0"/>
    <size width="67.0" height="56.0"/>
  </e…

View full answer

hsd-dev · 2022-05-30T15:52:28Z

hsd-dev
May 30, 2022
Author

In fillRootElement in print out

System.out.println(notationModel.getSemanticElement());
System.out.println(notationModel.getSemanticElement().getResolvedSemanticElement());

and the output is

org.eclipse.glsp.server.emf.model.notation.impl.SemanticElementReferenceImpl@62cac08f (elementId: root)
null

Both the .tasklist and .notation files pasted above are hand-created.

0 replies

hsd-dev · 2022-05-31T09:26:50Z

hsd-dev
May 31, 2022
Author

Added the following lines in fillRootElement

if (notationModel.getSemanticElement() != null) {

   if (notationModel.getSemanticElement().getResolvedSemanticElement() == null) {
      SemanticElementReference reference = NotationFactory.eINSTANCE.createSemanticElementReference();
      reference.setElementId(model.getName());
      notationModel.getSemanticElement().setResolvedSemanticElement(reference);
   }

And now it works. Is this the correct way or is this more like a hack?

1 reply

hsd-dev May 31, 2022
Author

this definitely seems like a hack, because every time the app starts or a new link is created, the nodes get repositioned to (0, 0) even thought the notation model contains the position information.

ndoschek · 2022-06-01T12:19:45Z

ndoschek
Jun 1, 2022
Collaborator

Hi @ipa-hsd!

Basically, the logic link between the semantic and the notation element is the SemanticElementReference.
To retrieve the notation information this reference is used to retrieve the position/size information.

In our java-emf-theia example, an id is used as element reference, in the following example the id 61bcc27a-3e93-4847-89e4-1d2433371b4b:

Semantic model example.tasklist:

...
  <tasks id="61bcc27a-3e93-4847-89e4-1d2433371b4b" name="NewTask0"/>
...

Notation model example.notation:

...
  <elements xsi:type="notation:Shape">
    <semanticElement elementId="61bcc27a-3e93-4847-89e4-1d2433371b4b"/>
    <position x="382.0" y="101.0"/>
    <size width="67.0" height="56.0"/>
  </elements>
...

To be able to apply the notation data when the GModel is created, it is necessary that the semantic element reference can be properly resolved (see also the applyShapeData method).

So in your case, I assume that this reference cannot be properly resolved only by the name of the link.
This also explains why the shapes are positioned at (0,0) as the corresponding shape element cannot be resolved.

So I suggest you use the same approach by assigning an id via the idGenerator as it is done in the java-emf-theia's CreateNodeTaskHandler (L#92).

HTH and best wishes,
Nina

8 replies

ndoschek Jun 3, 2022
Collaborator

Hi @ipa-hsd,

But the resolved semantic element still prints null in fillRootElement

System.out.println(notationModel.getSemanticElement());
// org.eclipse.glsp.server.emf.model.notation.impl.SemanticElementReferenceImpl@45633f5 (elementId: root)
System.out.println(notationModel.getSemanticElement().getResolvedSemanticElement());
// null

Regarding the resolved element: You could check the indexing process, set a breakpoint and see why the resolved element is not set/cannot be found here: createReference.

This file is not being generated for my Ecore model

Yes, this file is necessary and should usually be generated within the code generation via the .genmodel. Did you change any properties in the GenModel perhaps?

Somehow the idGenerator is not working

Did you bind the id generator correctly? E.g. as in the TaskListDiagramModule?

Maybe that's why the reference between notation and semantic element is not found?

Yes I assume so, if the ids keep disappearing, the resolving of semantic elements is probably not possible.

HTH, best wishes,

Nina

hsd-dev Jun 7, 2022
Author

createReference is never called for even the java-emf-theia example. The magic happens in resolveDiagram.

This line returns null for my use-case, but java-emf-theia example correctly returns root.

Did you bind the id generator correctly? E.g. as in the TaskListDiagramModule?

Yes

@Override
protected Class<? extends EMFIdGenerator> bindEMFIdGenerator() {
  // all our elements inherit from Identifiable and have an ID attribute set
  return AttributeIdGenerator.class;
}

hsd-dev Jun 7, 2022
Author

public class AttributeIdGenerator implements EMFIdGenerator {
   @Override
   public String getOrCreateId(final EObject element) {
      return EcoreUtil.getID(element);
   }
}

and in EcoreUtil.class

  public static java.lang.String getID(org.eclipse.emf.ecore.EObject eObject) {
    return null;
  }

I don't understand where is the correct implementation coming from for java-emf-theia.

martin-fleck-at Jun 7, 2022
Maintainer

@ipa-hsd Which version of EMF are you using? For me, org.eclipse.emf.ecore.util.EcoreUtil.class (from org.eclipse.emf.ecore_2.26.0.v20220123-0838 - but I assume it stayed mostly the same through most versions) looks like this:

 public static String getID(EObject eObject)
 {
   EClass eClass = eObject.eClass();
   EAttribute eIDAttribute = eClass.getEIDAttribute();
   return eIDAttribute == null || !eObject.eIsSet(eIDAttribute) ? null : convertToString(
     eIDAttribute.getEAttributeType(),
     eObject.eGet(eIDAttribute));
 }

So for the attribute ID generator to work you would need to set an explicit ID attribute in your metamodel (e.g., setting the iD="true" in https://github.com/eclipse-glsp/glsp-examples/blob/master/project-templates/java-emf-theia/glsp-server/model/model.ecore#L7).

hsd-dev Jun 7, 2022
Author

Ah finally!! had missed setting it to true :D thanks a lot

Nodes are not visualized in Theia #667

Uh oh!

Uh oh!

hsd-dev May 30, 2022

Replies: 3 comments · 9 replies

Uh oh!

hsd-dev May 30, 2022 Author

Uh oh!

Uh oh!

hsd-dev May 31, 2022 Author

Uh oh!

hsd-dev May 31, 2022 Author

Uh oh!

Uh oh!

ndoschek Jun 1, 2022 Collaborator

Uh oh!

ndoschek Jun 3, 2022 Collaborator

Uh oh!

hsd-dev Jun 7, 2022 Author

Uh oh!

Uh oh!

hsd-dev Jun 7, 2022 Author

Uh oh!

Uh oh!

martin-fleck-at Jun 7, 2022 Maintainer

Uh oh!

Uh oh!

hsd-dev Jun 7, 2022 Author

hsd-dev
May 30, 2022

Replies: 3 comments 9 replies

hsd-dev
May 30, 2022
Author

hsd-dev
May 31, 2022
Author

hsd-dev May 31, 2022
Author

ndoschek
Jun 1, 2022
Collaborator

ndoschek Jun 3, 2022
Collaborator

hsd-dev Jun 7, 2022
Author

hsd-dev Jun 7, 2022
Author

martin-fleck-at Jun 7, 2022
Maintainer

hsd-dev Jun 7, 2022
Author