No matching bindings found for serviceIdentifier

[csamarchi]

Hi again, when I launch my node server and GLSP VScode extension I get this error in the debug console:

(node:83544) UnhandledPromiseRejectionWarning: Error: No matching bindings found for serviceIdentifier: ModuleModelState

Meanwhile, the client extension endlessly stalls as shown below:

I have tried adding ModelState in my GModelDiagramModule file following this example like so and this does not solve it.

protected bindModuleModelState(): BindingTarget<ModelState> | undefined { return ModuleModelState; }

I was hoping someone could point me in the right direction or if you have any ideas.

Thanks!

[tortmayr]

HI @csamarchi,

if you want to bind a custom model state you have to override the bindModelState() method. I'd recommend to return a ServiceTarget. This ensures that both (@inject(ModelState) and @inject(ModuleModleState) resolve to the same instance:

    protected bindModelState(): BindingTarget<ModelState> {
        return { service: ModuleModelState };
    }

[csamarchi]

I removed the ovverride because i got the error This member cannot have an 'override' modifier because it is not declared in the base class 'GModelDiagramModule'.ts(4113)

[csamarchi]

So if you have a work around that error, I have to remove the override.

[csamarchi]

Is it possible to get around this error without using override?

[tortmayr]

I removed the ovverride because i got the error This member cannot have an 'override' modifier because it is not declared in the base class 'GModelDiagramModule'.ts(4113)
Is it possible to get around this error without using override?

Sorry, I'm afraid I can't follow. What exactly do you mean with I removed the override? The snippet I posted doesn't contain any override modifier and for me it compiles just fine without any errors.

What do you mean return a ServiceTarget

Each bind-Method (e.g. bindModelState()) expects a BindingTarget as return value.
Typically this is just the class you want to bind eg:

    protected bindActionDispatcher(): BindingTarget<ActionDispatcher> {
        return DefaultActionDispatcher;
    }

However, you can also return more complex BindingsTargets. The following code snippet returns a ServiceTarget:

protected bindModelState(): BindingTarget<ModelState> {
        return { service: ModuleModelState };
    }

So intead of a class your return an object with service property. Using a service target has the advantage that under the hood both ModelState and ModuleModelState are configured to use the same binding. So you can use either @inject(ModelState) or @inject(ModuleModleState) and will receive the same instance.

[tortmayr]

Ah I see, looks like the correct binding is :

protected override bindModelState(): BindingTarget<ModelState> {
        return { service: ModuleModelState };
}

I also prepared a simple working example that rebinds to a custom model state and injects the custom model state in the CreateWorkflowNodeOperationHandler class.

[csamarchi]

that's right, but I still am getting the binding error in my debug console for the server. Are you not getting this? It must have something to do with our model state we've created?

[csamarchi]

are you saying I should do the same with my node-operation-handle file and inject my custom model state in order for it to work? i am still getting the above error when doing so

[tortmayr]

The error you receive is not related to your custom model state, it's about bindings for ModuleModelIndex. I assume this is your custom implementation of GModelIndex? If so how did you bind it? You have to bind the same way as you did bind the ModelState:

    protected override bindGModelIndex(): BindingTarget<GModelIndex> {
        return { service: ModuleModelIndex };
    }

I have updated the example and it now also binds a custom model index.

are you saying I should do the same with my node-operation-handle file and inject my custom model state in order for it to work? i am still getting the above error when doing so

No, not all. I simply used the CreateWorkflowNodeOperationHandler class as an example to test whether the binding works.

[csamarchi]

Thank you, this helped a lot