Getting InaccessibleObjectException When Editing Label #702

Ginxss · 2022-07-10T10:36:14Z

Ginxss
Jul 10, 2022

Hi,

I have a theia client, java server and an EMF model (My code is based on this example project: https://github.com/eclipse-glsp/glsp-examples/tree/master/project-templates/java-emf-theia).

On my label, I have enabled the editLabelFeature.
The Node containing the label implements Nameable and WithEditableLabel and returns the editable Label in the editableLabel() method.

On the server, I have a class extending LabelEditValidator which just always returns ValidationStatus.ok() for now.
(The validator gets called on every letter that I type. Is that normal?)
I also have a class extending AbstractEMFOperationHandler<ApplyLabelEditOperation>, which renames the containing object.

When I edit a label, I get this error as soon as I start typing (In fact, I get this error on every letter that I type):

Juli 10, 2022 12:24:53 PM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint notify
WARNUNG: Failed to send notification message.
java.lang.reflect.InaccessibleObjectException: Unable to make private java.util.Collections$EmptyMap() accessible: module java.base does not "opens java.util" to unnamed module @23fe1d71
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
	at java.base/java.lang.reflect.Constructor.checkCanSetAccessible(Constructor.java:191)
	at java.base/java.lang.reflect.Constructor.setAccessible(Constructor.java:184)
	at com.google.gson.internal.ConstructorConstructor.newDefaultConstructor(ConstructorConstructor.java:101)
	at com.google.gson.internal.ConstructorConstructor.get(ConstructorConstructor.java:83)
	at com.google.gson.internal.bind.MapTypeAdapterFactory.create(MapTypeAdapterFactory.java:127)
	at com.google.gson.Gson.getAdapter(Gson.java:423)
	at com.google.gson.Gson.toJson(Gson.java:661)
	at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.writeProperty(PropertyBasedTypeAdapter.java:221)
	at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.writeProperties(PropertyBasedTypeAdapter.java:202)
	at org.eclipse.glsp.graph.gson.PropertyBasedTypeAdapter.write(PropertyBasedTypeAdapter.java:185)
	at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.write(TypeAdapterRuntimeTypeWrapper.java:69)
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.write(ReflectiveTypeAdapterFactory.java:125)
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.write(ReflectiveTypeAdapterFactory.java:243)
	at com.google.gson.Gson.toJson(Gson.java:669)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.write(MessageTypeAdapter.java:434)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.write(MessageTypeAdapter.java:55)
	at com.google.gson.Gson.toJson(Gson.java:669)
	at com.google.gson.Gson.toJson(Gson.java:648)
	at org.eclipse.lsp4j.jsonrpc.json.MessageJsonHandler.serialize(MessageJsonHandler.java:145)
	at org.eclipse.lsp4j.jsonrpc.json.MessageJsonHandler.serialize(MessageJsonHandler.java:140)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageConsumer.consume(StreamMessageConsumer.java:59)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.notify(RemoteEndpoint.java:126)
	at org.eclipse.lsp4j.jsonrpc.services.EndpointProxy.invoke(EndpointProxy.java:88)
	at jdk.proxy2/jdk.proxy2.$Proxy36.process(Unknown Source)
	at org.eclipse.glsp.server.actions.ClientActionHandler.send(ClientActionHandler.java:64)
	at org.eclipse.glsp.server.actions.ClientActionHandler.execute(ClientActionHandler.java:58)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.runAction(DefaultActionDispatcher.java:193)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.handleAction(DefaultActionDispatcher.java:172)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.dispatch(DefaultActionDispatcher.java:101)
	at org.eclipse.glsp.server.actions.ActionDispatcher.lambda$dispatchAll$0(ActionDispatcher.java:51)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at org.eclipse.glsp.server.actions.ActionDispatcher.dispatchAll(ActionDispatcher.java:51)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.runAction(DefaultActionDispatcher.java:196)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.handleAction(DefaultActionDispatcher.java:172)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.handleNextAction(DefaultActionDispatcher.java:159)
	at org.eclipse.glsp.server.internal.actions.DefaultActionDispatcher.runThread(DefaultActionDispatcher.java:145)
	at java.base/java.lang.Thread.run(Thread.java:833)

The error gets thrown after the ValidationStatus gets returned.

Even after all the exceptions, when I press enter (or even when I just drop focus), after about a second of delay, the apply edit operation gets invoked and the object gets renamed.

Any help on what is going on here and how to resolve this error would be greatly appreciated.

Thanks!

Answered by martin-fleck-at

Jul 11, 2022

Hi @Ginxss,

That is a very curious error since it does not seem to be caused by GLSP directly but within Gson while trying to serialize an empty list that should be sent to the client as part of an action. It might depend on the JDK that you are using as it seems that there is/was a known issue for Gson which is discussed here: google/gson#1875. I'll double check whether this is something we also face in our examples and whether a Gson upgrade will fix that but maybe you can also do a test locally to see if a newer Gson version fixes the issue for you as well. If that does not work we probably need to create a custom type adapter for this specific case. Just FYI, before the 1.0 release we…

View full answer

martin-fleck-at · 2022-07-11T07:45:21Z

martin-fleck-at
Jul 11, 2022
Maintainer

Hi @Ginxss,

That is a very curious error since it does not seem to be caused by GLSP directly but within Gson while trying to serialize an empty list that should be sent to the client as part of an action. It might depend on the JDK that you are using as it seems that there is/was a known issue for Gson which is discussed here: google/gson#1875. I'll double check whether this is something we also face in our examples and whether a Gson upgrade will fix that but maybe you can also do a test locally to see if a newer Gson version fixes the issue for you as well. If that does not work we probably need to create a custom type adapter for this specific case. Just FYI, before the 1.0 release we were using Gson 2.8.2 and now we are using Gson 2.8.9.

Regarding the edit label validation: Yes, at the moment it is expected that we validate the text on every key stroke as we do not know the validation logic so every character might be important. The base class that is installing this behavior is EditLabelUI and specifically this event registration: element.addEventListener('keyup', (event: KeyboardEvent) => this.validateLabelIfContentChange(event, element.value));.

9 replies

Ginxss Aug 3, 2022
Author

@martin-fleck-at Thank you!

Adding --add-opens java.base/java.util=ALL-UNNAMED as a JVM argument to the server call did the trick.

So, when I call the server with:
java --add-opens java.base/java.util=ALL-UNNAMED -jar [path to server] [add. arguments like port],
the server does not throw the error anymore.

For anyone curious, JVM arguments can be added as VSCode launch parameters like so in launch.json:

"vmArgs": [
    "--add-opens",
    "java.base/java.util=ALL-UNNAMED",
],

Now I'm just wondering if/how it's possible to add JVM arguments to the GLSPSocketServerContribution in the client, which would enable me to use the embedded server as well.

martin-fleck-at Aug 4, 2022
Maintainer

@Ginxss Glad that you managed to get it to run! That is a great idea, I definitely agree that adding it to the GLSPSocketServerContribution would be a great addition to ensure it also works for Java 17. If you have some time, we will gladly accept a PR for this otherwise I'll create a ticket and will try to find some time myself.

Ginxss Aug 5, 2022
Author

@martin-fleck-at Unfortunately I won't have time myself, but I would definitely appreciate it if this got added in the future.

martin-fleck-at Aug 12, 2022
Maintainer

@Ginxss I added the following issue #727 and PR eclipse-glsp/glsp-theia-integration#125. Do you think this will be sufficient or did you have to do some other modifications as well?

Ginxss Aug 15, 2022
Author

@martin-fleck-at Looks good to me!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Getting InaccessibleObjectException When Editing Label #702

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 9 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Getting InaccessibleObjectException When Editing Label #702

Uh oh!

Ginxss Jul 10, 2022

Replies: 1 comment · 9 replies

Uh oh!

Uh oh!

martin-fleck-at Jul 11, 2022 Maintainer

Uh oh!

Uh oh!

Ginxss Aug 3, 2022 Author

Uh oh!

martin-fleck-at Aug 4, 2022 Maintainer

Uh oh!

Ginxss Aug 5, 2022 Author

Uh oh!

martin-fleck-at Aug 12, 2022 Maintainer

Uh oh!

Ginxss Aug 15, 2022 Author

Ginxss
Jul 10, 2022

Replies: 1 comment 9 replies

martin-fleck-at
Jul 11, 2022
Maintainer

Ginxss Aug 3, 2022
Author

martin-fleck-at Aug 4, 2022
Maintainer

Ginxss Aug 5, 2022
Author

martin-fleck-at Aug 12, 2022
Maintainer

Ginxss Aug 15, 2022
Author