Merge pull request #2427 from FerdinandSpitzschnueffler/iox-2426-fix-gateway-channel

iox-#2426 Fix comparison operator in channel.inl

Author: FerdinandSpitzschnueffler

doc/website/release-notes/iceoryx-unreleased.md

@@ -146,7 +146,7 @@
 - Fix span span constructor assert when using begin/end constructor [#2253](https://github.com/eclipse-iceoryx/iceoryx/issues/2253)
 - Listener examples need to take all samples in the callback [#2251](https://github.com/eclipse-iceoryx/iceoryx/issues/2251)
 - 'iox::string' tests can exceed the translation unit compilation timeout [#2278](https://github.com/eclipse-iceoryx/iceoryx/issues/2278)
--  Building iceoryx with bazel on Windows is broken [#2320](https://github.com/eclipse-iceoryx/iceoryx/issues/2320)
+- Building iceoryx with bazel on Windows is broken [#2320](https://github.com/eclipse-iceoryx/iceoryx/issues/2320)
 - Fix wrong memory orders in SpscSoFi [#2177](https://github.com/eclipse-iceoryx/iceoryx/issues/2177)
 - ssize_t: redefinition; different basic types [#2209](https://github.com/eclipse-iceoryx/iceoryx/issues/2209)
 - Fix bazel build on macos [#2345](https://github.com/eclipse-iceoryx/iceoryx/issues/2345)
@@ -155,6 +155,7 @@
 - Depend on @ncurses when building with Bazel [#2372](https://github.com/eclipse-iceoryx/iceoryx/issues/2372)
 - Fix windows performance issue [#2377](https://github.com/eclipse-iceoryx/iceoryx/issues/2377)
 - Max Client and Server cannot be configured independently of Max Publisher and Subscriber [#2394](https://github.com/eclipse-iceoryx/iceoryx/issues/2394)
+- Fix call to non-existing `getService` in channel.inl [#2426](https://github.com/eclipse-iceoryx/iceoryx/issues/2426)
 
 **Refactoring:**
 

iceoryx_posh/include/iceoryx_posh/gateway/channel.hpp

@@ -22,7 +22,6 @@
 #include "iceoryx_posh/iceoryx_posh_types.hpp"
 #include "iox/expected.hpp"
 #include "iox/fixed_position_container.hpp"
-#include "iox/optional.hpp"
 
 #include <memory>
 

iceoryx_posh/include/iceoryx_posh/internal/gateway/channel.inl

@@ -50,7 +50,7 @@ template <typename IceoryxTerminal, typename ExternalTerminal>
 constexpr inline bool Channel<IceoryxTerminal, ExternalTerminal>::operator==(
     const Channel<IceoryxTerminal, ExternalTerminal>& rhs) const noexcept
 {
-    return m_service == rhs.getService();
+    return m_service == rhs.getServiceDescription();
 }
 
 template <typename IceoryxTerminal, typename ExternalTerminal>

iceoryx_posh/test/moduletests/test_gw_channel.cpp

@@ -62,4 +62,18 @@ TEST_F(ChannelTest, ReturnsErrorIfPoolExhausted)
     EXPECT_FALSE(channel.has_error());
 }
 
+TEST_F(ChannelTest, ComparisonWorks)
+{
+    ::testing::Test::RecordProperty("TEST_ID", "535de22b-575d-467c-810a-6beced4d4144");
+    auto channel1 = iox::gw::Channel<StubbedIceoryxTerminal, StubbedExternalTerminal>::create(
+        {"", "", ""}, StubbedIceoryxTerminal::Options());
+    ASSERT_FALSE(channel1.has_error());
+    EXPECT_TRUE(channel1 == channel1);
+
+    auto channel2 = iox::gw::Channel<StubbedIceoryxTerminal, StubbedExternalTerminal>::create(
+        {"Service", "", ""}, StubbedIceoryxTerminal::Options());
+    ASSERT_FALSE(channel2.has_error());
+    EXPECT_FALSE(channel1 == channel2);
+}
+
 } // namespace