iox-#2426 Fix comparison operator in channel.inl

Author: FerdinandSpitzschnueffler

iceoryx_posh/include/iceoryx_posh/gateway/channel.hpp

@@ -22,7 +22,6 @@
 #include "iceoryx_posh/iceoryx_posh_types.hpp"
 #include "iox/expected.hpp"
 #include "iox/fixed_position_container.hpp"
-#include "iox/optional.hpp"
 
 #include <memory>
 

iceoryx_posh/include/iceoryx_posh/internal/gateway/channel.inl

@@ -50,7 +50,7 @@ template <typename IceoryxTerminal, typename ExternalTerminal>
 constexpr inline bool Channel<IceoryxTerminal, ExternalTerminal>::operator==(
     const Channel<IceoryxTerminal, ExternalTerminal>& rhs) const noexcept
 {
-    return m_service == rhs.getService();
+    return m_service == rhs.getServiceDescription();
 }
 
 template <typename IceoryxTerminal, typename ExternalTerminal>

iceoryx_posh/test/moduletests/test_gw_channel.cpp

@@ -62,4 +62,18 @@ TEST_F(ChannelTest, ReturnsErrorIfPoolExhausted)
     EXPECT_FALSE(channel.has_error());
 }
 
+TEST_F(ChannelTest, ComparisonWorks)
+{
+    ::testing::Test::RecordProperty("TEST_ID", "535de22b-575d-467c-810a-6beced4d4144");
+    auto channel1 = iox::gw::Channel<StubbedIceoryxTerminal, StubbedExternalTerminal>::create(
+        {"", "", ""}, StubbedIceoryxTerminal::Options());
+    ASSERT_FALSE(channel1.has_error());
+    EXPECT_TRUE(channel1 == channel1);
+
+    auto channel2 = iox::gw::Channel<StubbedIceoryxTerminal, StubbedExternalTerminal>::create(
+        {"Service", "", ""}, StubbedIceoryxTerminal::Options());
+    ASSERT_FALSE(channel2.has_error());
+    EXPECT_FALSE(channel1 == channel2);
+}
+
 } // namespace