Merge pull request #2256 from elBoberido/iox-2011-fix-nightly-clang-tidy-check

iox-#2011 Rename 'string.cpp' to fix the clang-tidy check

Author: elBoberido

.github/workflows/build-test.yml

@@ -183,17 +183,18 @@ jobs:
           retention-days: 30
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           file: ./lcov_results/unittest/lcov/iceoryx_lcov_result_unit.info
           name: iceoryx
           flags: unittests
           fail_ci_if_error: false
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           file: ./lcov_results/unittest_timing/lcov/iceoryx_lcov_result_unit-timing.info
           name: iceoryx
           flags: unittests_timing
           fail_ci_if_error: false
+          token: ${{ secrets.CODECOV_TOKEN }}

iceoryx_platform/generic/source/string.cpp renamed to iceoryx_platform/generic/source/string_.cpp

@@ -14,6 +14,10 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+// NOTE: This file is called 'string_.cpp' due to issues with clang-tidy. When the file is called 'string.cpp'
+// clang-tidy assumes to be the translation unit for 'iox/string.hpp' tries to check that header with the wrong
+// translation unit which leads to an error not finding the includes in 'iox/string.hpp'
+
 #include "iceoryx_platform/string.hpp"
 
 #ifndef IOX_PLATFORM_OVERRIDE_STRING_ALL