iox-#2023 Improve error messages

Author: elBoberido

iceoryx_hoofs/posix/design/include/iox/file_management_interface.hpp

@@ -33,6 +33,7 @@ enum class FileStatError
 {
     IoFailure,
     FileTooLarge,
+    BadFileDescriptor,
     UnknownError,
 };
 
@@ -44,6 +45,7 @@ enum class FileSetOwnerError
     PermissionDenied,
     ReadOnlyFilesystem,
     InvalidUidOrGid,
+    BadFileDescriptor,
     UnknownError,
 };
 
@@ -52,6 +54,7 @@ enum class FileSetPermissionError
 {
     PermissionDenied,
     ReadOnlyFilesystem,
+    BadFileDescriptor,
     UnknownError,
 };
 

iceoryx_hoofs/posix/design/source/file_management_interface.cpp

@@ -32,6 +32,9 @@ expected<iox_stat, FileStatError> get_file_status(const int fildes) noexcept
     {
         switch (result.error().errnum)
         {
+        case EBADF:
+            IOX_LOG(ERROR, "The provided file descriptor is invalid.");
+            return err(FileStatError::BadFileDescriptor);
         case EIO:
             IOX_LOG(ERROR, "Unable to acquire file status since an io failure occurred while reading.");
             return err(FileStatError::IoFailure);
@@ -41,7 +44,7 @@ expected<iox_stat, FileStatError> get_file_status(const int fildes) noexcept
                     "corresponding structure.");
             return err(FileStatError::FileTooLarge);
         default:
-            IOX_LOG(ERROR, "Unable to acquire file status due to an unknown failure");
+            IOX_LOG(ERROR, "Unable to acquire file status due to an unknown failure. errno: " << result.error().errnum);
             return err(FileStatError::UnknownError);
         }
     }
@@ -57,6 +60,9 @@ expected<void, FileSetOwnerError> set_owner(const int fildes, const uid_t uid, c
     {
         switch (result.error().errnum)
         {
+        case EBADF:
+            IOX_LOG(ERROR, "The provided file descriptor is invalid.");
+            return err(FileSetOwnerError::BadFileDescriptor);
         case EPERM:
             IOX_LOG(ERROR, "Unable to set owner due to insufficient permissions.");
             return err(FileSetOwnerError::PermissionDenied);
@@ -75,7 +81,7 @@ expected<void, FileSetOwnerError> set_owner(const int fildes, const uid_t uid, c
             IOX_LOG(ERROR, "Unable to set owner since an interrupt was received.");
             return err(FileSetOwnerError::Interrupt);
         default:
-            IOX_LOG(ERROR, "Unable to set owner since an unknown error occurred.");
+            IOX_LOG(ERROR, "Unable to set owner since an unknown error occurred. errno: " << result.error().errnum);
             return err(FileSetOwnerError::UnknownError);
         }
     }
@@ -91,14 +97,18 @@ expected<void, FileSetPermissionError> set_permissions(const int fildes, const a
     {
         switch (result.error().errnum)
         {
+        case EBADF:
+            IOX_LOG(ERROR, "The provided file descriptor is invalid.");
+            return err(FileSetPermissionError::BadFileDescriptor);
         case EPERM:
             IOX_LOG(ERROR, "Unable to adjust permissions due to insufficient permissions.");
             return err(FileSetPermissionError::PermissionDenied);
         case EROFS:
             IOX_LOG(ERROR, "Unable to adjust permissions since it is a read-only filesystem.");
             return err(FileSetPermissionError::ReadOnlyFilesystem);
         default:
-            IOX_LOG(ERROR, "Unable to adjust permissions since an unknown error occurred.");
+            IOX_LOG(ERROR,
+                    "Unable to adjust permissions since an unknown error occurred. errno: " << result.error().errnum);
             return err(FileSetPermissionError::UnknownError);
         }
     }