Merge pull request #1328 from ekxide/iox2-1327-use-target-switch-instead-of-posix-feature

orecham · web-flow · commit f6787bf7baf9 · 2026-01-29T14:14:00.000+01:00
[#1327] Use target switches for POSIX usage instead of feature
diff --git a/Cargo.Bazel.lock b/Cargo.Bazel.lock
@@ -1,5 +1,5 @@
 {
-  "checksum": "1277e9a9ee7d849cba0a66cb83f4d3ea45a52da8efe6fe33a03d7f74fac9d1ab",
+  "checksum": "2294447d63760449f293a07ca48ba89d64093498189e12811ecfe2b1734f686a",
   "crates": {
     "addr2line 0.24.2": {
       "name": "addr2line",
diff --git a/MODULE.bazel.lock b/MODULE.bazel.lock
diff --git a/doc/release-notes/iceoryx2-unreleased.md b/doc/release-notes/iceoryx2-unreleased.md
@@ -42,6 +42,8 @@
     NOTE: Add new entries sorted by issue number to minimize the possibility of
     conflicts when merging.
 -->
+* Remove support for Bazel Workspaces
+  [#1263](https://github.com/eclipse-iceoryx/iceoryx2/issues/1263)
 * Adjust test names to naming convention
   [#1273](https://github.com/eclipse-iceoryx/iceoryx2/issues/1273)
 * Move character output abstraction into their own crate
@@ -51,8 +53,8 @@
 * Replace `lazy_static` dependency with `LazyLock` from `std` in `std` builds or
   a custom minimal spin-based implementation for `no_std` builds
   [#1321](https://github.com/eclipse-iceoryx/iceoryx2/issues/1321)
-* Remove support for Bazel Workspaces
-  [#1263](https://github.com/eclipse-iceoryx/iceoryx2/issues/1263)
+* Remove `posix` feature and use `cfg` switch based on target instead
+  [#1327](https://github.com/eclipse-iceoryx/iceoryx2/issues/1327)
 
 ### Workflow
 
diff --git a/examples/nostd/posix/rust/Cargo.toml b/examples/nostd/posix/rust/Cargo.toml
@@ -17,7 +17,7 @@ posix-nostd-publish-subscribe = { path = "publish-subscribe/" }
 posix-nostd-event = { path = "event/" }
 
 iceoryx2 = { path = "../../../../iceoryx2/", default-features = false }
-iceoryx2-bb-loggers = { path = "../../../../iceoryx2-bb/loggers", default-features = false, features = ["posix", "console"]}
+iceoryx2-bb-loggers = { path = "../../../../iceoryx2-bb/loggers", default-features = false, features = ["console"]}
 iceoryx2-bb-elementary-traits = { path = "../../../../iceoryx2-bb/elementary-traits" }
 iceoryx2-bb-memory = { path = "../../../../iceoryx2-bb/memory" }
 iceoryx2-bb-posix = { path = "../../../../iceoryx2-bb/posix" }
diff --git a/iceoryx2-bb/loggers/Cargo.toml b/iceoryx2-bb/loggers/Cargo.toml
@@ -16,16 +16,10 @@ workspace = true
 [features]
 default = []
 
-# Use the std module
 std = [
   "iceoryx2-bb-print/std",
   "iceoryx2-pal-concurrency-sync/std"
 ]
-# Use POSIX APIs
-posix = [
-  "iceoryx2-bb-print/posix",
-  "iceoryx2-pal-posix"
-]
 
 # Enables logging to buffer
 buffer = []
@@ -46,3 +40,9 @@ iceoryx2-pal-concurrency-sync = { workspace = true }
 
 log = { workspace = true, optional = true }
 tracing = { workspace = true, optional = true }
+
+[target.'cfg(target_os = "linux")'.dependencies]
+iceoryx2-pal-posix = { workspace = true }
+
+[target.'cfg(target_os = "nto")'.dependencies]
+iceoryx2-pal-posix = { workspace = true }
diff --git a/iceoryx2-bb/loggers/src/console.rs b/iceoryx2-bb/loggers/src/console.rs
@@ -47,7 +47,7 @@ fn duration_since_epoch() -> core::time::Duration {
             .duration_since(std::time::UNIX_EPOCH)
             .unwrap()
     }
-    #[cfg(feature = "posix")]
+    #[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]
     {
         use core::time::Duration;
         use iceoryx2_pal_posix::*;
@@ -65,7 +65,10 @@ fn duration_since_epoch() -> core::time::Duration {
         }
         Duration::from_secs(0)
     }
-    #[cfg(not(any(feature = "std", feature = "posix")))]
+    #[cfg(all(
+        not(feature = "std"),
+        not(any(target_os = "linux", target_os = "nto",))
+    ))]
     {
         Duration::from_secs(0)
     }
diff --git a/iceoryx2-bb/print/Cargo.toml b/iceoryx2-bb/print/Cargo.toml
@@ -13,12 +13,8 @@ version = { workspace = true }
 [features]
 default = []
 
-# Use the std module
 std = ["iceoryx2-pal-print/std"]
 
-# Use POSIX APIs
-posix = ["iceoryx2-pal-print/posix"]
-
 [dependencies]
 iceoryx2-pal-print = { workspace = true }
 
diff --git a/iceoryx2-pal/print/Cargo.toml b/iceoryx2-pal/print/Cargo.toml
@@ -12,15 +12,15 @@ version = { workspace = true }
 
 [features]
 default = []
-
-# Use the std module
 std = []
 
-# Use POSIX APIs
-posix = ["iceoryx2-pal-posix"]
-
 [dependencies]
-iceoryx2-pal-posix = { workspace = true, optional = true }
+
+[target.'cfg(target_os = "linux")'.dependencies]
+iceoryx2-pal-posix = { workspace = true }
+
+[target.'cfg(target_os = "nto")'.dependencies]
+iceoryx2-pal-posix = { workspace = true }
 
 [lints]
 workspace = true
diff --git a/iceoryx2-pal/print/src/writer.rs b/iceoryx2-pal/print/src/writer.rs
@@ -71,7 +71,7 @@ impl IsTerminal for Stderr {
     }
 }
 
-#[cfg(feature = "posix")]
+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]
 impl Write for Stdout {
     fn write_str(&mut self, s: &str) -> fmt::Result {
         use iceoryx2_pal_posix::*;
@@ -92,14 +92,14 @@ impl Write for Stdout {
     }
 }
 
-#[cfg(feature = "posix")]
+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]
 impl IsTerminal for Stdout {
     fn is_terminal(&self) -> bool {
         true
     }
 }
 
-#[cfg(feature = "posix")]
+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]
 impl Write for Stderr {
     fn write_str(&mut self, s: &str) -> fmt::Result {
         use iceoryx2_pal_posix::*;
@@ -120,35 +120,47 @@ impl Write for Stderr {
     }
 }
 
-#[cfg(feature = "posix")]
+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]
 impl IsTerminal for Stderr {
     fn is_terminal(&self) -> bool {
         true
     }
 }
 
-#[cfg(not(any(feature = "std", feature = "posix")))]
+#[cfg(all(
+    not(feature = "std"),
+    not(any(target_os = "linux", target_os = "nto",))
+))]
 impl Write for Stdout {
     fn write_str(&mut self, _s: &str) -> fmt::Result {
         Ok(())
     }
 }
 
-#[cfg(not(any(feature = "std", feature = "posix")))]
+#[cfg(all(
+    not(feature = "std"),
+    not(any(target_os = "linux", target_os = "nto",))
+))]
 impl IsTerminal for Stdout {
     fn is_terminal(&self) -> bool {
         false
     }
 }
 
-#[cfg(not(any(feature = "std", feature = "posix")))]
+#[cfg(all(
+    not(feature = "std"),
+    not(any(target_os = "linux", target_os = "nto",))
+))]
 impl Write for Stderr {
     fn write_str(&mut self, _s: &str) -> fmt::Result {
         Ok(())
     }
 }
 
-#[cfg(not(any(feature = "std", feature = "posix")))]
+#[cfg(all(
+    not(feature = "std"),
+    not(any(target_os = "linux", target_os = "nto",))
+))]
 impl IsTerminal for Stderr {
     fn is_terminal(&self) -> bool {
         false

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "checksum": "1277e9a9ee7d849cba0a66cb83f4d3ea45a52da8efe6fe33a03d7f74fac9d1ab",`
	`2`	`+ "checksum": "2294447d63760449f293a07ca48ba89d64093498189e12811ecfe2b1734f686a",`
`3`	`3`	`"crates": {`
`4`	`4`	`"addr2line 0.24.2": {`
`5`	`5`	`"name": "addr2line",`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ fn duration_since_epoch() -> core::time::Duration {`
`47`	`47`	`.duration_since(std::time::UNIX_EPOCH)`
`48`	`48`	`.unwrap()`
`49`	`49`	`}`
`50`		`- #[cfg(feature = "posix")]`
	`50`	`+ #[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]`
`51`	`51`	`{`
`52`	`52`	`use core::time::Duration;`
`53`	`53`	`use iceoryx2_pal_posix::*;`
`@@ -65,7 +65,10 @@ fn duration_since_epoch() -> core::time::Duration {`
`65`	`65`	`}`
`66`	`66`	`Duration::from_secs(0)`
`67`	`67`	`}`
`68`		`- #[cfg(not(any(feature = "std", feature = "posix")))]`
	`68`	`+ #[cfg(all(`
	`69`	`+ not(feature = "std"),`
	`70`	`+ not(any(target_os = "linux", target_os = "nto",))`
	`71`	`+ ))]`
`69`	`72`	`{`
`70`	`73`	`Duration::from_secs(0)`
`71`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ impl IsTerminal for Stderr {`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
`74`		`-#[cfg(feature = "posix")]`
	`74`	`+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]`
`75`	`75`	`impl Write for Stdout {`
`76`	`76`	`fn write_str(&mut self, s: &str) -> fmt::Result {`
`77`	`77`	`use iceoryx2_pal_posix::*;`
`@@ -92,14 +92,14 @@ impl Write for Stdout {`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`-#[cfg(feature = "posix")]`
	`95`	`+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]`
`96`	`96`	`impl IsTerminal for Stdout {`
`97`	`97`	`fn is_terminal(&self) -> bool {`
`98`	`98`	`true`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		`-#[cfg(feature = "posix")]`
	`102`	`+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]`
`103`	`103`	`impl Write for Stderr {`
`104`	`104`	`fn write_str(&mut self, s: &str) -> fmt::Result {`
`105`	`105`	`use iceoryx2_pal_posix::*;`
`@@ -120,35 +120,47 @@ impl Write for Stderr {`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
`123`		`-#[cfg(feature = "posix")]`
	`123`	`+#[cfg(all(not(feature = "std"), any(target_os = "linux", target_os = "nto",)))]`
`124`	`124`	`impl IsTerminal for Stderr {`
`125`	`125`	`fn is_terminal(&self) -> bool {`
`126`	`126`	`true`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`130`		`-#[cfg(not(any(feature = "std", feature = "posix")))]`
	`130`	`+#[cfg(all(`
	`131`	`+ not(feature = "std"),`
	`132`	`+ not(any(target_os = "linux", target_os = "nto",))`
	`133`	`+))]`
`131`	`134`	`impl Write for Stdout {`
`132`	`135`	`fn write_str(&mut self, _s: &str) -> fmt::Result {`
`133`	`136`	`Ok(())`
`134`	`137`	`}`
`135`	`138`	`}`
`136`	`139`
`137`		`-#[cfg(not(any(feature = "std", feature = "posix")))]`
	`140`	`+#[cfg(all(`
	`141`	`+ not(feature = "std"),`
	`142`	`+ not(any(target_os = "linux", target_os = "nto",))`
	`143`	`+))]`
`138`	`144`	`impl IsTerminal for Stdout {`
`139`	`145`	`fn is_terminal(&self) -> bool {`
`140`	`146`	`false`
`141`	`147`	`}`
`142`	`148`	`}`
`143`	`149`
`144`		`-#[cfg(not(any(feature = "std", feature = "posix")))]`
	`150`	`+#[cfg(all(`
	`151`	`+ not(feature = "std"),`
	`152`	`+ not(any(target_os = "linux", target_os = "nto",))`
	`153`	`+))]`
`145`	`154`	`impl Write for Stderr {`
`146`	`155`	`fn write_str(&mut self, _s: &str) -> fmt::Result {`
`147`	`156`	`Ok(())`
`148`	`157`	`}`
`149`	`158`	`}`
`150`	`159`
`151`		`-#[cfg(not(any(feature = "std", feature = "posix")))]`
	`160`	`+#[cfg(all(`
	`161`	`+ not(feature = "std"),`
	`162`	`+ not(any(target_os = "linux", target_os = "nto",))`
	`163`	`+))]`
`152`	`164`	`impl IsTerminal for Stderr {`
`153`	`165`	`fn is_terminal(&self) -> bool {`
`154`	`166`	`false`