fix(microservice): add ports volumeMappings and routes in info response (ENG-250)

Author: mchepelev

src/services/microservices-service.js

@@ -42,8 +42,22 @@ async function listMicroservices(flowId, user, isCLI, transaction) {
   const where = isCLI ? {delete: false} : {flowId: flowId, delete: false};
 
   const microservices = await MicroserviceManager.findAllExcludeFields(where, transaction);
+
+  const res = await Promise.all(microservices.map(async (microservice) => {
+    const microserviceUuid = microservice.uuid;
+    const portMappings = await MicroservicePortManager.findAll({microserviceUuid: microserviceUuid}, transaction);
+    const volumeMappings = await VolumeMappingManager.findAll({microserviceUuid: microserviceUuid}, transaction);
+    const routes = await RoutingManager.findAll({sourceMicroserviceUuid: microserviceUuid}, transaction);
+
+    const fullMs = Object.assign({}, microservice.dataValues);
+    fullMs.ports = portMappings.map((pm) =>  {return {internal: pm.portInternal, external: pm.portExternal, publicMode: pm.isPublic}});
+    fullMs.volumeMappings = volumeMappings.map(vm => vm.dataValues);
+    fullMs.routes = routes.map(r => r.destMicroserviceUuid);
+
+    return fullMs;
+  }));
   return {
-    microservices: microservices
+    microservices: res
   }
 }
 
@@ -59,7 +73,16 @@ async function getMicroservice(microserviceUuid, user, isCLI, transaction) {
   if (!microservice) {
     throw new Errors.NotFoundError(AppHelper.formatMessage(ErrorMessages.INVALID_MICROSERVICE_UUID, microserviceUuid));
   }
-  return microservice;
+
+  const portMappings = await MicroservicePortManager.findAll({microserviceUuid: microserviceUuid}, transaction);
+  const volumeMappings = await VolumeMappingManager.findAll({microserviceUuid: microserviceUuid}, transaction);
+  const routes = await RoutingManager.findAll({sourceMicroserviceUuid: microserviceUuid}, transaction);
+
+  const res = Object.assign({}, microservice.dataValues);
+  res.ports = portMappings.map((pm) =>  {return {internal: pm.portInternal, external: pm.portExternal, publicMode: pm.isPublic}});
+  res.volumeMappings = volumeMappings.map(vm => vm.dataValues);
+  res.routes = routes.map(r => r.destMicroserviceUuid);
+  return res;
 }
 
 async function createMicroservice(microserviceData, user, isCLI, transaction) {

test/src/services/microservices-service.test.js

@@ -41,9 +41,15 @@ describe('Microservices Service', () => {
 
     def('subject', () => $subject.listMicroservices(flowId, user, isCLI, transaction));
     def('findMicroservicesResponse', () => Promise.resolve(response));
+    def('findPortMappingsResponse', () => Promise.resolve([]));
+    def('findVolumeMappingsResponse', () => Promise.resolve([]));
+    def('findRoutesResponse', () => Promise.resolve([]));
 
     beforeEach(() => {
       $sandbox.stub(MicroserviceManager, 'findAllExcludeFields').returns($findMicroservicesResponse);
+      $sandbox.stub(MicroservicePortManager, 'findAll').returns($findPortMappingsResponse);
+      $sandbox.stub(VolumeMappingManager, 'findAll').returns($findVolumeMappingsResponse);
+      $sandbox.stub(RoutingManager, 'findAll').returns($findRoutesResponse);
     });
 
     it('calls MicroserviceManager#findAllExcludeFields() with correct args', async () => {
@@ -79,14 +85,22 @@ describe('Microservices Service', () => {
     const microserviceUuid = 'testMicroserviceUuid';
 
     const response = {
-      uuid: 'testUuid'
+      dataValues: {
+        uuid: 'testUuid'
+      }
     };
 
     def('subject', () => $subject.getMicroservice(microserviceUuid, user, isCLI, transaction));
     def('findMicroserviceResponse', () => Promise.resolve(response));
+    def('findPortMappingsResponse', () => Promise.resolve([]));
+    def('findVolumeMappingsResponse', () => Promise.resolve([]));
+    def('findRoutesResponse', () => Promise.resolve([]));
 
     beforeEach(() => {
       $sandbox.stub(MicroserviceManager, 'findOneExcludeFields').returns($findMicroserviceResponse);
+      $sandbox.stub(MicroservicePortManager, 'findAll').returns($findPortMappingsResponse);
+      $sandbox.stub(VolumeMappingManager, 'findAll').returns($findVolumeMappingsResponse);
+      $sandbox.stub(RoutingManager, 'findAll').returns($findRoutesResponse);
     });
 
     it('calls MicroserviceManager#findOneExcludeFields() with correct args', async () => {