processor sources are unmaintained in j.compiler.apt.tests (#4753)

+ refresh git-manages sources from jar files
+ unify LF (unix)
+ clean-up: whitespace, imports, diamond, StringBuffer -> StringBuilder
+ run Create Jar on *.jardesc
+ remove stale build files

#4751

Author: stephan-herrmann

org.eclipse.jdt.compiler.apt.tests/.externalToolBuilders/Build processors jar.launch

@@ -20,16 +20,6 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
-		<buildCommand>
-			<name>org.eclipse.ui.externaltools.ExternalToolBuilder</name>
-			<triggers>full,incremental,</triggers>
-			<arguments>
-				<dictionary>
-					<key>LaunchConfigHandle</key>
-					<value>&lt;project&gt;/.externalToolBuilders/Build processors jar.launch</value>
-				</dictionary>
-			</arguments>
-		</buildCommand>
 	</buildSpec>
 	<natures>
 		<nature>org.eclipse.pde.PluginNature</nature>

org.eclipse.jdt.compiler.apt.tests/.project

@@ -11,20 +11,20 @@
         </sealing>
     </manifest>
     <selectedElements exportClassFiles="true" exportJavaFiles="true" exportOutputFolder="false">
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.visitors"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.annotations"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.base"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.checkargs"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.elements"/>
         <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.elementutils"/>
         <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.filer"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.elements"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors8=/test=/true=/"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.typemirror"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.genclass"/>
         <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.generics"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.checkargs"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.inherited"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.messager"/>
         <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.negative"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.genclass"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.typemirror"/>
         <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.typeutils"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.messager"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.base"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.inherited"/>
-        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.annotations"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors=/test=/true=/&lt;org.eclipse.jdt.compiler.apt.tests.processors.visitors"/>
+        <javaElement handleIdentifier="=org.eclipse.jdt.compiler.apt.tests/processors8=/test=/true=/"/>
     </selectedElements>
 </jardesc>

org.eclipse.jdt.compiler.apt.tests/apttestprocessors8.jardesc

@@ -22,7 +22,7 @@
  * If {@code warn == true}, the processor produces source code that will cause a
  * warning about an unused variable when compiled (if the warning is enabled).
  * </p>
- * 
+ *
  * @see org.eclipse.jdt.compiler.apt.tests.processors.genclass.GenClassProc
  */
 public @interface GenClass {

org.eclipse.jdt.compiler.apt.tests/lib/apttestprocessors.jar

@@ -66,7 +66,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
 		return ALLOW_OTHER_PROCESSORS_TO_PROCESS;
 	}
 
-	private static class GenericTypeVisitor extends SimpleTypeVisitor6<DeclaredType, Void> {
+	private class GenericTypeVisitor extends SimpleTypeVisitor6<DeclaredType, Void> {
 		private final Types types;
 		@Deprecated
 		public GenericTypeVisitor(Types types) {

org.eclipse.jdt.compiler.apt.tests/lib/apttestprocessors8.jar

@@ -29,6 +29,7 @@ public abstract class BaseProcessor extends AbstractProcessor
 
 	/**
 	 * Report an error to the test case code
+	 * @param value
 	 */
 	public void reportError(String value) {
 		// Debugging - don't report error
@@ -40,8 +41,7 @@ public void reportError(String value) {
 	 * Report success to the test case code
 	 */
 	public void reportSuccess() {
-		if (System.getProperty(this.getClass().getName()) == null)
-			System.setProperty(this.getClass().getName(), "succeeded");
+		System.setProperty(this.getClass().getName(), "succeeded");
 	}
 
 	public void reportFailure() {

org.eclipse.jdt.compiler.apt.tests/processors/org/eclipse/jdt/compiler/apt/tests/annotations/GenClass.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2023 BEA Systems, Inc.
+ * Copyright (c) 2008 BEA Systems, Inc.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -26,6 +26,7 @@
 import java.util.Map.Entry;
 import java.util.Set;
 import java.util.TreeMap;
+import javax.xml.parsers.DocumentBuilderFactory;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import org.w3c.dom.NamedNodeMap;
@@ -62,7 +63,7 @@ public class XMLComparer implements IXMLNames {
 	 *
 	 * @since 3.4
 	 */
-	private static class DeclarationContents {
+	private class DeclarationContents {
 		Element annotations = null;
 		Element superclass = null;
 		Element interfaces = null;
@@ -139,6 +140,7 @@ public void write(int b) throws IOException {
 	 * this class to compare it to a known reference model.  The models
 	 * should match.
 	 * @return true if the models matched, i.e., if the test passed
+	 * @throws Exception
 	 */
 	public static boolean test() throws Exception {
 		final String XML_FRAMEWORK_TEST_MODEL =
@@ -161,7 +163,8 @@ public static boolean test() throws Exception {
 			"</model>\n";
 
 		// create "actual" model
-		Document actualModel = org.eclipse.core.internal.runtime.XmlProcessorFactory.createDocumentBuilderWithErrorOnDOCTYPE().newDocument();
+		DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+		Document actualModel = factory.newDocumentBuilder().newDocument();
 		Element modelNode = actualModel.createElement(MODEL_TAG);
 		// primary type
 		Element typeNode = actualModel.createElement(TYPE_ELEMENT_TAG);
@@ -199,7 +202,7 @@ public static boolean test() throws Exception {
 
 		// load reference model
     	InputSource source = new InputSource(new StringReader(XML_FRAMEWORK_TEST_MODEL));
-        Document expectedModel = org.eclipse.core.internal.runtime.XmlProcessorFactory.createDocumentBuilderWithErrorOnDOCTYPE().parse(source);
+        Document expectedModel = factory.newDocumentBuilder().parse(source);
 
         // compare actual and reference
         ByteArrayOutputStream out = new ByteArrayOutputStream();

org.eclipse.jdt.compiler.apt.tests/processors/org/eclipse/jdt/compiler/apt/tests/processors/AnnotationProcessorTests/Bug340635Proc.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2023 BEA Systems, Inc.
+ * Copyright (c) 2008 BEA Systems, Inc.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -28,6 +28,7 @@
 import javax.lang.model.element.VariableElement;
 import javax.lang.model.type.TypeMirror;
 import javax.lang.model.util.ElementScanner6;
+import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.transform.OutputKeys;
 import javax.xml.transform.Transformer;
@@ -62,7 +63,7 @@ public static String xmlToString(Document model) {
 		StringWriter s = new StringWriter();
 		DOMSource domSource = new DOMSource(model);
 		StreamResult streamResult = new StreamResult(s);
-		TransformerFactory tf = org.eclipse.core.internal.runtime.XmlProcessorFactory.createTransformerFactoryWithErrorOnDOCTYPE();
+		TransformerFactory tf = TransformerFactory.newInstance();
 		Transformer serializer;
 		try {
 			serializer = tf.newTransformer();
@@ -140,9 +141,11 @@ public static String xmlToCutAndPasteString(Document model, int indent, boolean
 	 * Recursively convert a collection of language elements (declarations) into an XML representation.
 	 * @param declarations the collection of language elements to convert
 	 * @return an XML document whose root node is named <model>.
+	 * @throws ParserConfigurationException
 	 */
 	public static Document convertModel(Iterable<? extends javax.lang.model.element.Element> declarations) throws ParserConfigurationException {
-		Document model = org.eclipse.core.internal.runtime.XmlProcessorFactory.createDocumentBuilderWithErrorOnDOCTYPE().newDocument();
+		DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+		Document model = factory.newDocumentBuilder().newDocument();
 		org.w3c.dom.Element modelNode = model.createElement(MODEL_TAG);
 
 		XMLConverter converter = new XMLConverter(model);
@@ -308,6 +311,8 @@ private void convertInterfaces(TypeElement e, Node target) {
 
 	/**
 	 * Create a node representing a class declaration's superclass
+	 * @param tmSuper
+	 * @param target
 	 */
 	private void convertSuperclass(TypeElement e, Node target) {
 		TypeMirror tmSuper = e.getSuperclass();