code optimisation

Author: subyssurendran666

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java

@@ -26,7 +26,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import org.eclipse.jdt.core.compiler.CharOperation;
 import org.eclipse.jdt.core.compiler.InvalidInputException;
 import org.eclipse.jdt.internal.compiler.ast.TypeReference;
@@ -1394,30 +1393,8 @@ protected boolean parseReference() throws InvalidInputException {
 		return parseReference(false);
 	}
 
-	// Checks if current identifier is a URL scheme (http, https, ftp, etc.)
-	private boolean isURLScheme(char[] identifier) {
-	    return CharOperation.equals("http".toCharArray(), identifier) || //$NON-NLS-1$
-	           CharOperation.equals("https".toCharArray(), identifier) || //$NON-NLS-1$
-	           CharOperation.equals("ftp".toCharArray(), identifier) || //$NON-NLS-1$
-	           CharOperation.equals("file".toCharArray(), identifier); //$NON-NLS-1$
-	}
-
-	// Checks if the current position is followed by "://" URL pattern
-	private boolean isFollowedByURLPattern() {
-		int pos = this.scanner.currentPosition;
-		try {
-			if (pos + 2 >= this.source.length) return false;
-
-			return this.source[pos] == ':' &&
-		               this.source[pos + 1] == '/' &&
-		               this.source[pos + 2] == '/';
-		} catch(Exception e) {
-			return false;
-		}
-	}
-
 	// Parses a complete URL reference starting from current position
-	private Object parseURLReference(boolean httpFlag) throws InvalidInputException {
+	private Object parseURLReference() throws InvalidInputException {
 		// httpFlag is used to check wheather URL contains http or not
 		StringBuilder urlBuilder = new StringBuilder();
 		int firstTokenStartPos = this.scanner.startPosition;
@@ -1428,75 +1405,34 @@ private Object parseURLReference(boolean httpFlag) throws InvalidInputException
 		}
 		char[] fullURL;
 		int pos;
-		if (httpFlag) {
-			// Add :
-			TerminalToken token1 = readTokenSafely();
-			if (token1 == TerminalToken.TokenNameCOLON) {
-				urlBuilder.append(this.scanner.getCurrentTokenSource());
-				consumeToken();
-			}
 
-			pos = this.scanner.getCurrentTokenEndPosition() + 1;
-			char c;
-			while (pos < this.source.length) {
-				c = (this.source[pos] == ')') ? this.source[pos] : readChar();
-
-				if (c == ':') continue;
-		        if (c == ' ' || c == '\t' || c == '\n' || c == '\r' || c == '*' || c == ')' || c == '(' || c == '[' || c == ']' ) {
-		            break;
-		        }
-		        urlBuilder.append(c);
-		        pos++;
-			}
-			fullURL = urlBuilder.toString().toCharArray();
-		} else {
+		TerminalToken token1 = readTokenSafely();
+		if (token1 == TerminalToken.TokenNameCOLON) {
+			urlBuilder.append(this.scanner.getCurrentTokenSource());
+			consumeToken();
+		}
 
-			//process the second token
-			TerminalToken token1 = readTokenSafely();
-			if (token1 == TerminalToken.TokenNameDOT) {
-				urlBuilder.append(this.scanner.getCurrentTokenSource());
-				consumeToken();
-			}
+		pos = this.scanner.getCurrentTokenEndPosition() + 1;
+		char c;
+		while (pos < this.source.length) {
+			c = (this.source[pos] == ')') ? this.source[pos] : readChar();
 
-			TerminalToken token2 = readTokenSafely();
-			if (token2 == TerminalToken.TokenNameIdentifier) {
-				urlBuilder.append(this.scanner.getCurrentTokenSource());
-			}
-			pos = this.scanner.getCurrentTokenEndPosition() + 1;
-			fullURL = urlBuilder.toString().toCharArray();
+			if (c == ':') continue;
+	        if (c == ' ' || c == '\t' || c == '\n' || c == '\r' || c == '*' || c == ')' || c == '(' || c == '[' || c == ']' ) {
+	            break;
+	        }
+	        urlBuilder.append(c);
+	        pos++;
 		}
+		fullURL = urlBuilder.toString().toCharArray();
+
 		this.identifierPtr = 0;
 		this.identifierStack[this.identifierPtr] =  fullURL;
 		this.identifierPositionStack[this.identifierPtr] = (((long) firstTokenStartPos) << 32) + (pos - 1);
 		this.identifierLengthStack[this.identifierLengthPtr] = 1;
 		return createTypeReference(TokenNameInvalid, true);
 	}
 
-	// Ensure the markdown URL bracket syntax follows []() or [][]
-	private void checkMarkdownLinkSyntaxValid(int currStartPos, boolean httpFlag) {
-		// httpFlag is used to check wheather URL contains http or not
-		char secondBracket = this.source[currStartPos - 2];
-		char thirdBracket = this.source[currStartPos - 1];
-
-		char[] generatedURL = this.identifierStack[this.identifierPtr];
-		char fourthBracket = this.source[currStartPos + generatedURL.length];
-
-		String pattern = new String(new char[] {secondBracket, thirdBracket, fourthBracket});
-		//invalid bracket patterns
-		Set<String> invalidPatterns = Set.of(
-				")[)", //$NON-NLS-1$
-			    "](]", //$NON-NLS-1$
-			    ")[]", //$NON-NLS-1$
-			    "][)", //$NON-NLS-1$
-			    "([)", //$NON-NLS-1$
-			    "(][", //$NON-NLS-1$
-			    "[)(", //$NON-NLS-1$
-			    "(](" //$NON-NLS-1$
-		);
-		if (invalidPatterns.contains(pattern)) this.abort = true;
-
-	}
-
 	/*
 	 * Parse a reference in @see tag
 	 */
@@ -1593,27 +1529,14 @@ else if (this.tagValue == TAG_VALUE_VALUE) {
 					case TokenNameUNDERSCORE:
 					case TokenNameIdentifier :
 						if (this.markdown) {
-							char[] identifier = this.scanner.getCurrentIdentifierSource();
 							int pos1 = this.scanner.getCurrentTokenStartPosition() - 1;
 							while (pos1 >= 0 && Character.isWhitespace(this.source[pos1])) {
 							    pos1--;
 							}
 							if (pos1 >= 0 && this.source[pos1] == '(') {
-								if (isURLScheme(identifier)) {
-									if (isFollowedByURLPattern()) {
-										if (typeRef == null) {
-											int currStartPos = this.scanner.startPosition;
-											typeRefStartPosition = this.scanner.getCurrentTokenStartPosition();
-											typeRef = parseURLReference(true);
-											checkMarkdownLinkSyntaxValid(currStartPos, true);
-											if (this.abort) return false;
-										}
-									}
-								} else if (this.source[this.scanner.getCurrentTokenEndPosition() +1 ] == '.') {
-									int currStartPos = this.scanner.startPosition;
+								if (typeRef == null) {
 									typeRefStartPosition = this.scanner.getCurrentTokenStartPosition();
-									typeRef = parseURLReference(false);
-									checkMarkdownLinkSyntaxValid(currStartPos, true);
+									typeRef = parseURLReference();
 									if (this.abort) return false;
 								}
 							}