ECJ fails to complain about static member being selected from a

parameterized
class

* Fixes #4702

Author: srikanth-sankaran

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/ParameterizedQualifiedTypeReference.java

@@ -244,7 +244,7 @@ private TypeBinding internalResolveLeafType(Scope scope, boolean checkBounds) {
 				if (this.annotations != null)
 					rejectAnnotationsOnStaticMemberQualififer(scope, currentType, this.annotations[i-1]);
 				if (typeIsConsistent && currentType.isStatic()
-						&& (qualifyingType.isParameterizedTypeWithActualArguments() || qualifyingType.isGenericType())) {
+						&& (qualifyingType.isParameterizedType() || qualifyingType.isGenericType())) {
 					scope.problemReporter().staticMemberOfParameterizedType(this, currentType, qualifyingType, i);
 					typeIsConsistent = false;
 					qualifyingType = qualifyingType.actualType(); // avoid raw/parameterized enclosing of static member

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/QualifiedTypeReference.java

@@ -159,6 +159,10 @@ protected TypeBinding getTypeBinding(Scope scope) {
 				if (this.annotations != null) {
 					rejectAnnotationsOnStaticMemberQualififer(scope, currentType, this.annotations[i-1]);
 				}
+				if (currentType.isStatic() && (qualifyingType.isParameterizedType() || qualifyingType.isGenericType())) {
+					scope.problemReporter().staticMemberOfParameterizedType(this, currentType, qualifyingType, i);
+					qualifyingType = qualifyingType.actualType(); // avoid raw/parameterized enclosing of static member
+				}
 				ReferenceBinding enclosingType = currentType.enclosingType();
 				if (enclosingType != null && TypeBinding.notEquals(enclosingType.erasure(), qualifyingType.erasure())) {
 					qualifyingType = enclosingType; // inherited member type, leave it associated with its enclosing rather than subtype
@@ -178,7 +182,10 @@ protected TypeBinding getTypeBinding(Scope scope) {
 					}
 				}
 			} else {
-				qualifyingType = currentType.isGenericType() ? (ReferenceBinding)scope.environment().convertToRawType(currentType, false /*do not force conversion of enclosing types*/) : currentType;
+				qualifyingType = currentType.isGenericType() ?
+							(ReferenceBinding)scope.environment().convertToRawType(currentType, false /*do not force conversion of enclosing types*/) :
+							scope.environment().convertToParameterizedType(currentType);
+
 			}
 			recordResolution(scope.environment(), qualifyingType);
 		}

org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericsRegressionTest_9.java

@@ -2034,6 +2034,113 @@ interface MyCallable<U, F extends Exception> extends Callable<U> {
 	});
 }
 
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4702
+// ecj ignores error "cannot select a static class from a parameterized type"
+public void testIssue4702() {
+	if (this.complianceLevel < ClassFileConstants.JDK16)
+		return;
+	runNegativeTest(new String[] {
+		"OuterStaticNestedDemo.java",
+		"""
+		public class OuterStaticNestedDemo<E> {
+		    class Outer {
+		        static class StaticNested {}
+		    }
+
+		    void qualifiedNew(Outer outer) {
+		        new OuterStaticNestedDemo<String>.Outer.StaticNested();
+		    }
+		}
+		"""
+	},
+		"----------\n" +
+		"1. ERROR in OuterStaticNestedDemo.java (at line 7)\n" +
+		"	new OuterStaticNestedDemo<String>.Outer.StaticNested();\n" +
+		"	    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
+		"The member type OuterStaticNestedDemo.Outer.StaticNested cannot be qualified with a parameterized type, since it is static. Remove arguments from qualifying type OuterStaticNestedDemo<String>.Outer\n" +
+		"----------\n");
+}
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4702
+// ecj ignores error "cannot select a static class from a parameterized type"
+public void testIssue4702_1() {
+	if (this.complianceLevel < ClassFileConstants.JDK16)
+		return;
+	runNegativeTest(new String[] {
+		"OuterStaticNestedDemo.java",
+		"""
+		public class OuterStaticNestedDemo<E> {
+		    class Outer {
+		        static class StaticNested {}
+		    }
+
+		    void qualifiedNew(Outer outer) {
+		        new Outer.StaticNested();
+		    }
+		}
+		"""
+	},
+		"----------\n" +
+		"1. ERROR in OuterStaticNestedDemo.java (at line 7)\n" +
+		"	new Outer.StaticNested();\n" +
+		"	    ^^^^^^^^^^^^^^^^^^\n" +
+		"The member type OuterStaticNestedDemo.Outer.StaticNested cannot be qualified with a parameterized type, since it is static. Remove arguments from qualifying type OuterStaticNestedDemo<E>.Outer\n" +
+		"----------\n");
+}
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4702
+// ecj ignores error "cannot select a static class from a parameterized type"
+public void testIssue4702_2() {
+	if (this.complianceLevel < ClassFileConstants.JDK16)
+		return;
+	runNegativeTest(new String[] {
+		"OuterStaticNestedDemo.java",
+		"""
+		class OuterStaticNestedBase<E> {
+		    class Outer {
+		        static class StaticNested {}
+		    }
+		}
+		class OuterStaticNestedDemo<E> extends OuterStaticNestedBase<E> {
+
+
+		    void qualifiedNew(Outer outer) {
+		        new Outer.StaticNested();
+		    }
+		}
+		"""
+	},
+		"----------\n" +
+		"1. ERROR in OuterStaticNestedDemo.java (at line 10)\n" +
+		"	new Outer.StaticNested();\n" +
+		"	    ^^^^^^^^^^^^^^^^^^\n" +
+		"The member type OuterStaticNestedBase.Outer.StaticNested cannot be qualified with a parameterized type, since it is static. Remove arguments from qualifying type OuterStaticNestedBase<E>.Outer\n" +
+		"----------\n");
+}
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4702
+// ecj ignores error "cannot select a static class from a parameterized type"
+public void testIssue4702_3() {
+	if (this.complianceLevel < ClassFileConstants.JDK16)
+		return;
+	runNegativeTest(new String[] {
+		"OuterStaticNestedDemo.java",
+		"""
+		public class OuterStaticNestedDemo<E> {
+		    class Outer<T> {
+		        static class StaticNested {}
+		    }
+
+		    void qualifiedNew(Outer outer) {
+		        new Outer.StaticNested();
+		    }
+		}
+		"""
+	},
+			"----------\n" +
+			"1. WARNING in OuterStaticNestedDemo.java (at line 6)\n" +
+			"	void qualifiedNew(Outer outer) {\n" +
+			"	                  ^^^^^\n" +
+			"OuterStaticNestedDemo.Outer is a raw type. References to generic type OuterStaticNestedDemo<E>.Outer<T> should be parameterized\n" +
+			"----------\n");
+}
 public static Class<GenericsRegressionTest_9> testClass() {
 	return GenericsRegressionTest_9.class;
 }