[Performance] Full build takes more time since 2024-09 (type inference) (#3387)

optimize 3:
+ never visit the same super type more than once

Fixes #3327

Author: stephan-herrmann

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/BoundSet.java

@@ -1264,8 +1264,14 @@ private boolean superOnlyRaw(TypeBinding g, TypeBinding s, LookupEnvironment env
 	}
 
 	protected List<Pair<TypeBinding>> allSuperPairsWithCommonGenericType(TypeBinding s, TypeBinding t) {
+		return allSuperPairsWithCommonGenericTypeRecursive(s, t, new HashSet<>());
+	}
+
+	private List<Pair<TypeBinding>> allSuperPairsWithCommonGenericTypeRecursive(TypeBinding s, TypeBinding t, HashSet<TypeBinding> visited) {
 		if (s == null || s.id == TypeIds.T_JavaLangObject || t == null || t.id == TypeIds.T_JavaLangObject)
 			return Collections.emptyList();
+		if (!visited.add(s.prototype()))
+			return Collections.emptyList();
 		List<Pair<TypeBinding>> result = new ArrayList<>();
 		if (s.isParameterizedType() && t.isParameterizedType() // optimization #1: clients of this method only want to compare type arguments
 				&& TypeBinding.equalsEquals(s.original(), t.original())) {
@@ -1277,11 +1283,11 @@ protected List<Pair<TypeBinding>> allSuperPairsWithCommonGenericType(TypeBinding
 		if (tSuper != null && s.isParameterizedType() && tSuper.isParameterizedType()) { // optimization #1 again
 			result.add(new Pair<>(s, tSuper));
 		}
-		result.addAll(allSuperPairsWithCommonGenericType(s.superclass(), t));
+		result.addAll(allSuperPairsWithCommonGenericTypeRecursive(s.superclass(), t, visited));
 		ReferenceBinding[] superInterfaces = s.superInterfaces();
 		if (superInterfaces != null) {
 			for (ReferenceBinding superInterface : superInterfaces) {
-				result.addAll(allSuperPairsWithCommonGenericType(superInterface, t));
+				result.addAll(allSuperPairsWithCommonGenericTypeRecursive(superInterface, t, visited));
 			}
 		}
 		return result;