in-corporate code review comments

Author: subyssurendran666

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java

@@ -1404,34 +1404,36 @@ protected boolean parseURLReference() throws InvalidInputException {
 			firstTokenStartPos = this.index;
 			while (pos < this.source.length) {
 				c =  readChar();
-				if (c == '(' || c == '[' || c == ' ')
+				if (c == '[') // invalid syntax for url
+					return false;
+				if (c == '(' || c == ' ')
 					continue;
 
-		        if (c == '\t' || c == '\n' || c == '\r' || c == '*' || c == ')' || c == '[' || c == ']' ) {
+		        if (c == '\n' || c == '\r' || c == ')' ) {
 		            break;
 		        }
 		        urlBuilder.append(c);
 			}
 			pos = this.index - 1;
-			if (validateMarkdownSyntax(this.source[firstTokenStartPos], this.source[pos]))
-				fullURL = urlBuilder.toString().toCharArray();
+			fullURL = urlBuilder.toString().toCharArray();
 		} else {
 			pos = this.scanner.startPosition - 1;
 			firstTokenStartPos = pos;
 			while (pos < this.source.length) {
 				c = this.source[pos];
-				if (c == '(' || c == '[' || c == ' ') {
+				if (c == '[') // invalid syntax for url
+					return false;
+				if (c == '(' || c == ' ') {
 					pos++;
 					continue;
 				}
-				if (c == '\t' || c == '\n' || c == '\r' || c == '*' || c == ')' || c == '[' || c == ']' ) {
+				if (c == '\n' || c == '\r' || c == ')') {
 		            break;
 		        }
 		        urlBuilder.append(c);
 		        pos++;
 			}
-			if (validateMarkdownSyntax(this.source[firstTokenStartPos], this.source[pos]))
-				fullURL = urlBuilder.toString().toCharArray();
+			fullURL = urlBuilder.toString().toCharArray();
 		}
 
 		this.identifierPtr = 0;
@@ -1443,11 +1445,6 @@ protected boolean parseURLReference() throws InvalidInputException {
 		return true;
 	}
 
-	/// validate markdown syntax check
-	private boolean validateMarkdownSyntax(char start, char end) {
-		return (start == '[' && end == ']') || (start == '(' && end == ')');
-	}
-
 	/*
 	 * Parse a reference in @see tag
 	 */

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterMarkdownTest.java

@@ -2027,7 +2027,11 @@ public class Markdown() {}
 			CompilationUnit compilUnit = (CompilationUnit) runConversion(this.workingCopies[0], true);
 			TypeDeclaration typedeclaration =  (TypeDeclaration) compilUnit.types().get(0);
 			Javadoc javadoc = typedeclaration.getJavadoc();
-			assertEquals("Tags count does not match", 0, javadoc.tags().size());
+			assertEquals("Tags count does not match", 1, javadoc.tags().size());
+			TagElement tags = (TagElement) javadoc.tags().get(0);
+			assertTrue(tags.fragments().get(0) instanceof TextElement);
+			assertTrue(tags.fragments().get(1) instanceof TextElement);
+			assertTrue(tags.fragments().get(2) instanceof TextElement);
 		}
 	}