Difference of sp_cleanup and cleanup in org.eclipse.jdt.ui.prefs

[laeubi]

I try to improve the integration of cleanup preferences in Tycho and found some thing that is a bit confusing

We have all preferences in two flavors, one with cleanup. prefix and one with sp_cleanup. in the org.eclipse.jdt.ui.prefs

• The first one is set when I go to project preferences > cleanup and enable project specific settings there
• The second is set when I go to project preferences > save actions > additional actions

So when we talk about "taking project preference into account" should one use the first? Or the second? or simply merge both?

Should one to get a consistent behavior in the IDE maybe set both values to the same? Should there be two options in Tycho (useSaveProfile vs useProjectCleanupProfile)?

@jjohnstn or other can you give a hint here?

[jjohnstn]

I ran a few tests. The save cleanups in additional actions are only being applied when the user saves the file in the editor. They aren't being run after a user runs cleanups. Does the tycho plug-in intend to run these separately after applying the clean-ups? If not, then you don't need to worry about them.

[laeubi]

The save cleanups in additional actions are only being applied when the user saves the file in the editor. They aren't being run after a user runs cleanups.

As Tycho only run once and users can use both approach I think we need to simply support both and can even enable the sp_ ones by default (if save actions are enabled). Do you think that's reasonable?

Another option would be to have a config option to either use one or the other what also have some benefits. Or I can look if save actions are enabled, then use the save-profile and otherwise the other what might be the most automated way...

[jjohnstn]

I think having an option is the best idea. I may have save actions that I only want to apply if I change a file, but don't want to run on all files (e.g. I might put reformatting cleanups in save actions as I don't want to reformat all files - just the ones I change).