java.lang.StackOverflowError during "Requesting Java AST from selection"

[nlisker]

Eclipse soft crashes during hover over some fields with a SOE and asks to restart. This also breaks the compilation, as after this error, many red lines appear saying that various methods can't be found suddenly.

The first lines of the stack traces are different every time, but the recursion is always the same. Here is the log with various cases of these errors: crashes.log

Here is the infinite recursion (I don't know what the entry point was):

	at org.eclipse.jdt.internal.compiler.Compiler.accept(Compiler.java:365)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.accept(CompilationUnitResolver.java:226)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.accept(CompilationUnitResolver.java:221)
	at org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:391)
	at org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:275)
	at org.eclipse.jdt.internal.compiler.lookup.CompilationUnitScope.findImport(CompilationUnitScope.java:643)
	at org.eclipse.jdt.internal.compiler.lookup.CompilationUnitScope.resolveImports(CompilationUnitScope.java:325)
	at org.eclipse.jdt.internal.compiler.lookup.CompilationUnitScope.checkAndSetImports(CompilationUnitScope.java:284)
	at org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment$CompleteTypeBindingsSteps.perform(LookupEnvironment.java:191)
	at org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.completeTypeBindings(LookupEnvironment.java:602)
	at org.eclipse.jdt.internal.compiler.Compiler.accept(Compiler.java:365)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.accept(CompilationUnitResolver.java:226)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.accept(CompilationUnitResolver.java:221)

While I can reproduce this 100% of the times, unfortunately I didn't manage to create a minimal example despite many hours of chopping off parts of the big project where this occurs. This is because the error becomes harder and harder to reproduce the more code is removed, which means that there is a certain load affecting this issue.
I can't post a whole project here, but if there is a way to send the project or post it somewhere private I will do so.

Tested on
Eclipse 4.33 and also build id: I20241101-1800
Java 22
Win 10

[srikanth-sankaran]

I can't post a whole project here, but if there is a way to send the project or post it somewhere private I will do so.

I don't have a place to suggest, but if you organize such a place, I offer to investigate. My ideal reproducer will be a plain vanilla SDK project without layers like maven, gradle etc if possible - I am not familiar with these and it will impede progress. Thanks

[srikanth-sankaran]

I need a few more days though - this week looks tough. I have been burning the midnight candle at both ends if you don't mind my mixing the metaphor :), trying to squeeze in improved support for sealed types as well as switch expressions in 4.34.

I'll let you know once I am able to spare some cycles (later half of next week looks likely

[nlisker]

I sent you an invite to the private repo with instructions in the only open issue there. Thank you for taking a look!

Amber features take priority :)

[srikanth-sankaran]

See also

#1081
#1490
#2301

the former has some reduced test case. The last one has a junit too. Need to see if they are all related or even the same

[srikanth-sankaran]

I have verified I am able to access the private repo, clone the repo and import the projects and see the instructions. No luck yet reproducing, but I will spend more time on this next week

[srikanth-sankaran]

In the meantime you may want to check if the hover that triggers the crash is over some symbol statically imported given static imports feature prominently in the other tickets with SOE.

[nlisker]

I'll try to narrow it down. For now I'm even getting multiple occurrences

[nlisker]

Also, the crash can also happen on clicking a tab in the editor (switching files), not just on hover.

[srikanth-sankaran]

This looks nasty. Hopefully we can get to the bottom of it soon.

Deeper stack traces may help.

Also at some point we can consider a version of eclipse that would log some data. We need to identify what to log.

[nlisker]

I think managed to narrow it down to a Web Tools feature that is installed in the background. When an Eclipse with that component opens the project it somehow corrupts it, then any Eclipse that will open it should see the same issue. I'll update the reproduction instructions. Even if it's a bug with a plugin, it bubbles to a full JDT stack trace as shown in the first comment (which is why it's so hard to find where the problem is).

[nlisker]

Instructions updated with screenshots.

[nlisker]

Any update on this?

[srikanth-sankaran]

Not yet. I'll spend time on it tomorrow.

[srikanth-sankaran]

Drowned in this #3310 🙂 but I can context switch tomorrow