"IAE at `org.eclipse.jdt.core.Signature.encodeQualifiedName`" on hyperlink request

[nlisker]

Split from eclipse-jdt/eclipse.jdt.ui#2286.

import java.util.concurrent.Callable;

public class Test {

	public static <T> void createObjectBinding(final Callable<T> func) {
		return;
	}

	sealed interface Index {
		enum SS implements Index {}
		enum TS implements Index {}
	}
	
	public abstract sealed class Entity<S extends Index> permits Struct, Time {}
	
	final class Struct extends Entity<Index.SS> {}
	
	final class Time extends Entity<Index.TS> {
		
		Struct getStruct() {
			return null;
		}

		public Object getOther() {
			return null;
		}
	}
	
	private <T> T createMap(Object other) {
		return null;
	}
	
	private void setMaterials(Time entity) {
		var selfIllumImage = createObjectBinding(() -> {
				var entity2 = entity.getStruct() == null ? entity : entity.getStruct();
				return createMap(entity.getOther());
		});
	}
}

Hold ctrl and hover over entity2. Here the exception is IAE:

java.lang.IllegalArgumentException: generics.Test.Entity<? extends java.lang.Enum<?> & generics.Test.Index>
	at org.eclipse.jdt.core.Signature.encodeQualifiedName(Signature.java:1384)
	at org.eclipse.jdt.core.Signature.encodeTypeSignature(Signature.java:1506)
	at org.eclipse.jdt.core.Signature.encodeTypeSignature(Signature.java:1483)
	at org.eclipse.jdt.core.Signature.encodeTypeSignature(Signature.java:1514)
	at org.eclipse.jdt.core.Signature.createCharArrayTypeSignature(Signature.java:1106)
	at org.eclipse.jdt.core.Signature.createTypeSignature(Signature.java:1304)
	at org.eclipse.jdt.internal.core.SelectionRequestor.acceptLocalVariable(SelectionRequestor.java:428)
	at org.eclipse.jdt.internal.codeassist.SelectionEngine.selectFrom(SelectionEngine.java:1353)
	at org.eclipse.jdt.internal.codeassist.SelectionEngine.select(SelectionEngine.java:1043)
	at org.eclipse.jdt.internal.core.Openable.codeSelect(Openable.java:171)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeSelect(CompilationUnit.java:476)
	at org.eclipse.jdt.internal.core.CompilationUnit.codeSelect(CompilationUnit.java:466)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinksCached(JavaElementHyperlinkDetector.java:127)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.lambda$0(JavaElementHyperlinkDetector.java:84)
	at org.eclipse.jdt.internal.core.JavaModelManager.cacheZipFiles(JavaModelManager.java:5708)
	at org.eclipse.jdt.internal.core.JavaModelManager.callReadOnly(JavaModelManager.java:5697)
	at org.eclipse.jdt.core.JavaCore.callReadOnly(JavaCore.java:6156)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinks(JavaElementHyperlinkDetector.java:84)
	at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:81)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:289)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:262)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:457)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:250)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4360)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1214)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4158)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3746)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:678)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:185)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:627)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1431)
	Suppressed: java.lang.Throwable: Source line 43 :
-----
			return null;
		}
	}
	
	private <T> T createMap(Object other) {
		return null;
	}
	
	private void setMaterials(Time entity) {
		var selfIllumImage = createObjectBinding(() -> {
				var e|ntity2 = entity.getStruct() == null ? entity : entity.getStruct();
-----
		at org.eclipse.jdt.internal.ui.util.SelectionUtil.logException(SelectionUtil.java:157)
		at org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinksCached(JavaElementHyperlinkDetector.java:146)
		... 34 more

Eclipse Java Development Tools 3.20.300.v20250618-2149
Eclipse Platform 4.37.0.I20250618-1800

[srikanth-sankaran]

Not a recent problem. I can reproduce this > 15 versions earlier in SDK 4.20

[srikanth-sankaran]

Seems like bad side effect from https://bugs.eclipse.org/bugs/show_bug.cgi?id=537014

Comment says: // loop on type[&type]*

but we are actually looping on type[&type][type]* or some such.

@stephan-herrmann you may want to look through the fix in #4834

(you may want to hide white space before comparing)

[stephan-herrmann]

Seems like bad side effect from https://bugs.eclipse.org/bugs/show_bug.cgi?id=537014

Comment says: // loop on type[&type]*

but we are actually looping on type[&type][type]* or some such.

This sure didn't look right. Ooops.

I think I tried to mimic how . was handled above, which should have looked like this:

		if (checkPos > 0) {
			if (buffer.charAt(0) != C_UNION) // the constant name is wrong, its value is correct :-X
				buffer.insert(0, C_UNION);
			buffer.append(C_COLON);
-			pos = encodeTypeSignature(typeName, checkPos, isResolved, length, buffer);
-			if (pos == length) {
-				break;
-			}
+			pos = checkPos;
		} else {
			break;
		}

With an additional consumeWhitespace(..) this would've actually worked :)

@stephan-herrmann you may want to look through the fix in #4834

(you may want to hide white space before comparing)

looks good. 👍

[nlisker]

With I20260216-1800 - no NEP on hover, but when choosing "open declared type" I get

java.lang.IllegalArgumentException: "&Lhover.Bug4218.Entity<+Ljava.lang.Enum<*>;:Lhover.Bug4218.Index;>;" at 43
	at org.eclipse.jdt.internal.compiler.util.Util.newIllegalArgumentException(Util.java:1577)
	at org.eclipse.jdt.internal.compiler.util.Util.scanTypeSignature(Util.java:1176)
	at org.eclipse.jdt.internal.compiler.util.Util.scanTypeArgumentSignature(Util.java:1503)
	at org.eclipse.jdt.internal.compiler.util.Util.scanTypeArgumentSignatures(Util.java:1467)
	at org.eclipse.jdt.internal.compiler.util.Util.scanClassTypeSignature(Util.java:1368)
	at org.eclipse.jdt.core.Signature.getUnionTypeBounds(Signature.java:1666)
	at org.eclipse.jdt.core.Signature.getUnionTypeBounds(Signature.java:1707)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaElementDeclaredTypeHyperlink.open(JavaElementDeclaredTypeHyperlink.java:139)
	at org.eclipse.jface.text.hyperlink.MultipleHyperlinkPresenter$LinkListInformationControl.openSelectedLink(MultipleHyperlinkPresenter.java:361)
	at org.eclipse.jface.text.hyperlink.MultipleHyperlinkPresenter$LinkListInformationControl$4.mouseUp(MultipleHyperlinkPresenter.java:331)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:262)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4349)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1217)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4147)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3735)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1160)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1051)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:684)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:185)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1415)

[srikanth-sankaran]

With I20260216-1800 - no NEP on hover, but when choosing "open declared type" I get

java.lang.IllegalArgumentException

Can you open a fresh ticket please ? Is this a new regression ? Mention that here and in the new issue too. Thanks!

[nlisker]

With I20260216-1800 - no NEP on hover, but when choosing "open declared type" I get
java.lang.IllegalArgumentException

Can you open a fresh ticket please ? Is this a new regression ? Mention that here and in the new issue too. Thanks!

Filed #4853. I can't tell if it's technically a regression because the menu didn't appear before this fix, so either a new bug was uncovered, or this fix caused it (I'm guessing the former).