Skip to content

Commit 11fb0a6

Browse files
gzsomboriloveeclipse
authored andcommitted
Fix NPE, which triggered when 'Show variable details' reverted to the default value, when PreferenceChangeEvent.newValue is actually null
1 parent 119ab72 commit 11fb0a6

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/variables/JavaVariableLabelProvider.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -220,16 +220,12 @@ protected void retrieveLabel(ILabelUpdate update) throws CoreException {
220220
* @param value preference value for PREF_SHOW_DETAILS
221221
*/
222222
private void determineSerializationMode(String value) {
223-
switch (value) {
224-
case IJDIPreferencesConstants.INLINE_ALL:
225-
fSerializeMode = SERIALIZE_NONE;
226-
break;
227-
case IJDIPreferencesConstants.INLINE_FORMATTERS:
228-
fSerializeMode = SERIALIZE_SOME;
229-
break;
230-
default:
231-
fSerializeMode = SERIALIZE_ALL;
232-
break;
223+
if (IJDIPreferencesConstants.INLINE_ALL.equals(value)) {
224+
fSerializeMode = SERIALIZE_NONE;
225+
} else if (IJDIPreferencesConstants.INLINE_FORMATTERS.equals(value)) {
226+
fSerializeMode = SERIALIZE_SOME;
227+
} else {
228+
fSerializeMode = SERIALIZE_ALL;
233229
}
234230
}
235231

0 commit comments

Comments
 (0)