StackFramePresentationProvider should not be AutoClosable

gzsombor · akurtakov · commit bc288872932d · 2024-11-27T08:57:12.000+02:00
it just triggers a bunch of warning
diff --git a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/StackFramePresentationProvider.java b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/StackFramePresentationProvider.java
@@ -37,7 +37,7 @@
  * preference storage.
  *
  */
-public class StackFramePresentationProvider implements IPropertyChangeListener, AutoCloseable {
+public final class StackFramePresentationProvider implements IPropertyChangeListener {
 
 	private final static EnumMap<Category, String> fgKeyMap = new EnumMap<>(Map.of(
 			Category.CUSTOM_FILTERED, IJDIPreferencesConstants.PREF_CUSTOM_FILTERED_STACK_FRAME_FG_COLOR,
@@ -267,7 +267,6 @@ private Category categorizeSourceElement(IJavaStackFrame frame) {
 		return Category.UNKNOWN;
 	}
 
-	@Override
 	public void close() {
 		store.removePropertyChangeListener(this);
 	}

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`* preference storage.`
`38`	`38`	`*`
`39`	`39`	`*/`
`40`		`-public class StackFramePresentationProvider implements IPropertyChangeListener, AutoCloseable {`
	`40`	`+public final class StackFramePresentationProvider implements IPropertyChangeListener {`
`41`	`41`
`42`	`42`	`private final static EnumMap<Category, String> fgKeyMap = new EnumMap<>(Map.of(`
`43`	`43`	`Category.CUSTOM_FILTERED, IJDIPreferencesConstants.PREF_CUSTOM_FILTERED_STACK_FRAME_FG_COLOR,`
`@@ -267,7 +267,6 @@ private Category categorizeSourceElement(IJavaStackFrame frame) {`
`267`	`267`	`return Category.UNKNOWN;`
`268`	`268`	`}`
`269`	`269`
`270`		`- @Override`
`271`	`270`	`public void close() {`
`272`	`271`	`store.removePropertyChangeListener(this);`
`273`	`272`	`}`