Skip to content

Commit 6e94b0f

Browse files
holly-cumminsiloveeclipse
authored andcommitted
Use class names for selectors to avoid locking in classloader
Fixes #2257 Use the class name in the selector, rather than a class object, to avoid 'locking in' the classloader of the class. Locking in the class prevents thread context classloaders being used in the discovery phase to load classes.
1 parent 88f3297 commit 6e94b0f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

org.eclipse.jdt.junit5.runtime/src/org/eclipse/jdt/internal/junit5/runner/JUnit5TestLoader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ private ITestReference createFilteredTest(Class<?> clazz, String testName, Strin
7575
}
7676

7777
private ITestReference createUnfilteredTest(Class<?> clazz, String[][] includeExcludeTags, String[] failureNames) {
78-
LauncherDiscoveryRequestBuilder requestBuilder= LauncherDiscoveryRequestBuilder.request().selectors(DiscoverySelectors.selectClass(clazz)).filters(getTagFilters(includeExcludeTags));
78+
LauncherDiscoveryRequestBuilder requestBuilder= LauncherDiscoveryRequestBuilder.request().selectors(DiscoverySelectors.selectClass(clazz.getName())).filters(getTagFilters(includeExcludeTags));
7979
if (failureNames != null && failureNames.length > 0) {
8080
String failureNamesString= ""; //$NON-NLS-1$
8181
for (String failureName : failureNames) {

0 commit comments

Comments
 (0)