Skip to content

Commit d88c617

Browse files
authored
CallHierarchy: use Core constants (#1706)
1 parent 3948ff8 commit d88c617

File tree

2 files changed

+17
-14
lines changed
  • org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy
  • org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy

2 files changed

+17
-14
lines changed

org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ public class CallHierarchyCore {
5050
public static final String PREF_HIDE_TEST_CODE = "PREF_HIDE_TEST_CODE"; //$NON-NLS-1$
5151
public static final String PREF_SHOW_TEST_CODE_ONLY = "PREF_SHOW_TEST_CODE_ONLY"; //$NON-NLS-1$
5252

53-
private static final String PREF_USE_IMPLEMENTORS= "PREF_USE_IMPLEMENTORS"; //$NON-NLS-1$
54-
private static final String PREF_USE_FILTERS= "PREF_USE_FILTERS"; //$NON-NLS-1$
55-
private static final String PREF_FILTERS_LIST= "PREF_FILTERS_LIST"; //$NON-NLS-1$
56-
53+
public static final String PREF_USE_IMPLEMENTORS= "PREF_USE_IMPLEMENTORS"; //$NON-NLS-1$
54+
public static final String PREF_USE_FILTERS= "PREF_USE_FILTERS"; //$NON-NLS-1$
55+
public static final String PREF_FILTERS_LIST= "PREF_FILTERS_LIST"; //$NON-NLS-1$
5756
private String defaultIgnoreFilters= "java.*,javax.*"; //$NON-NLS-1$
5857

5958
private static CallHierarchyCore fgInstance;

org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchy.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@
1717
*******************************************************************************/
1818
package org.eclipse.jdt.internal.corext.callhierarchy;
1919

20+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_FILTERS_LIST;
21+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_HIDE_TEST_CODE;
22+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_SHOW_ALL_CODE;
23+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_SHOW_TEST_CODE_ONLY;
24+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_FILTERS;
25+
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_IMPLEMENTORS;
26+
2027
import java.util.Collection;
2128
import java.util.List;
2229

@@ -36,11 +43,8 @@
3643
import org.eclipse.jdt.internal.ui.JavaPlugin;
3744
import org.eclipse.jdt.internal.ui.util.StringMatcher;
3845

39-
public class CallHierarchy {
4046

41-
private static final String PREF_USE_IMPLEMENTORS= "PREF_USE_IMPLEMENTORS"; //$NON-NLS-1$
42-
private static final String PREF_USE_FILTERS = "PREF_USE_FILTERS"; //$NON-NLS-1$
43-
private static final String PREF_FILTERS_LIST = "PREF_FILTERS_LIST"; //$NON-NLS-1$
47+
public class CallHierarchy {
4448

4549
private static CallHierarchy fgInstance;
4650
private CallHierarchyCore fgCallHierarchyCore;
@@ -58,17 +62,17 @@ public static CallHierarchy getDefault() {
5862

5963
public void setShowAll(boolean value) {
6064
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
61-
settings.setValue(CallHierarchyCore.PREF_SHOW_ALL_CODE, value);
65+
settings.setValue(PREF_SHOW_ALL_CODE, value);
6266
}
6367

6468
public void setHideTestCode(boolean value) {
6569
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
66-
settings.setValue(CallHierarchyCore.PREF_HIDE_TEST_CODE, value);
70+
settings.setValue(PREF_HIDE_TEST_CODE, value);
6771
}
6872

6973
public void setShowTestCode(boolean value) {
7074
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
71-
settings.setValue(CallHierarchyCore.PREF_SHOW_TEST_CODE_ONLY, value);
75+
settings.setValue(PREF_SHOW_TEST_CODE_ONLY, value);
7276
}
7377

7478
public boolean isSearchUsingImplementorsEnabled() {
@@ -137,17 +141,17 @@ public boolean isFilterEnabled() {
137141

138142
public boolean isShowAll() {
139143
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
140-
return settings.getBoolean(CallHierarchyCore.PREF_SHOW_ALL_CODE);
144+
return settings.getBoolean(PREF_SHOW_ALL_CODE);
141145
}
142146

143147
public boolean isHideTestCode() {
144148
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
145-
return settings.getBoolean(CallHierarchyCore.PREF_HIDE_TEST_CODE);
149+
return settings.getBoolean(PREF_HIDE_TEST_CODE);
146150
}
147151

148152
public boolean isShowTestCode() {
149153
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore();
150-
return settings.getBoolean(CallHierarchyCore.PREF_SHOW_TEST_CODE_ONLY);
154+
return settings.getBoolean(PREF_SHOW_TEST_CODE_ONLY);
151155
}
152156

153157

0 commit comments

Comments
 (0)