Fix insertion for enum constants

mickaelistria · mickaelistria · commit 106aa2238820 · 2025-03-31T15:58:53.000+02:00
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java
@@ -3949,6 +3949,12 @@ private CompletionProposal toProposal(IBinding binding, String completion) {
 					}
 				}
 			}
+			if (variableBinding.isEnumConstant()
+					&& toComplete.getLocationInParent() != FieldAccess.NAME_PROPERTY
+					&& toComplete.getLocationInParent() != SwitchCase.EXPRESSION_PROPERTY
+					&& toComplete.getLocationInParent() != SwitchCase.EXPRESSIONS2_PROPERTY) {
+				res.setCompletion((variableBinding.getDeclaringClass().getName() + '.' + variableBinding.getName()).toCharArray());
+			}
 		} else if (kind == CompletionProposal.TYPE_REF) {
 			var typeBinding = (ITypeBinding) binding;
 			res.setSignature(SignatureUtils.getSignatureChar(typeBinding));

Original file line number	Diff line number	Diff line change
`@@ -3949,6 +3949,12 @@ private CompletionProposal toProposal(IBinding binding, String completion) {`
`3949`	`3949`	`}`
`3950`	`3950`	`}`
`3951`	`3951`	`}`
	`3952`	`+ if (variableBinding.isEnumConstant()`
	`3953`	`+ && toComplete.getLocationInParent() != FieldAccess.NAME_PROPERTY`
	`3954`	`+ && toComplete.getLocationInParent() != SwitchCase.EXPRESSION_PROPERTY`
	`3955`	`+ && toComplete.getLocationInParent() != SwitchCase.EXPRESSIONS2_PROPERTY) {`
	`3956`	`+ res.setCompletion((variableBinding.getDeclaringClass().getName() + '.' + variableBinding.getName()).toCharArray());`
	`3957`	`+ }`
`3952`	`3958`	`} else if (kind == CompletionProposal.TYPE_REF) {`
`3953`	`3959`	`var typeBinding = (ITypeBinding) binding;`
`3954`	`3960`	`res.setSignature(SignatureUtils.getSignatureChar(typeBinding));`