JavaSearchTests.testCoreException - CoreException should be propagated, not caught

Rob Stryker · robstryker · commit 1bb87f375f67 · 2025-02-13T14:29:33.000-05:00
Signed-off-by: Rob Stryker &lt;stryker@redhat.com&gt;
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/core/search/DOMJavaSearchDelegate.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/core/search/DOMJavaSearchDelegate.java
@@ -175,11 +175,7 @@ public void acceptAST(org.eclipse.jdt.core.ICompilationUnit source,
 				int level = wrapper.trustedASTNodeLevels.get(node);
 				SearchMatch match = toMatch(locator, node, level, possibleMatch);
 				if (match != null && match.getElement() != null) {
-					try {
-						SearchMatchingUtility.reportSearchMatch(locator, match);
-					} catch (CoreException ex) {
-						ILog.get().error(ex.getMessage(), ex);
-					}
+					SearchMatchingUtility.reportSearchMatch(locator, match);
 				}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -175,11 +175,7 @@ public void acceptAST(org.eclipse.jdt.core.ICompilationUnit source,`
`175`	`175`	`int level = wrapper.trustedASTNodeLevels.get(node);`
`176`	`176`	`SearchMatch match = toMatch(locator, node, level, possibleMatch);`
`177`	`177`	`if (match != null && match.getElement() != null) {`
`178`		`- try {`
`179`		`- SearchMatchingUtility.reportSearchMatch(locator, match);`
`180`		`- } catch (CoreException ex) {`
`181`		`- ILog.get().error(ex.getMessage(), ex);`
`182`		`- }`
	`178`	`+ SearchMatchingUtility.reportSearchMatch(locator, match);`
`183`	`179`	`}`
`184`	`180`	`}`
`185`	`181`	`}`