Verify method parameter types to return accuracy

Author: mickaelistria

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/core/search/matching/DOMMethodLocator.java

@@ -31,6 +31,7 @@
 import org.eclipse.jdt.core.dom.ASTNode;
 import org.eclipse.jdt.core.dom.Annotation;
 import org.eclipse.jdt.core.dom.AnnotationTypeMemberDeclaration;
+import org.eclipse.jdt.core.dom.ConstructorInvocation;
 import org.eclipse.jdt.core.dom.Expression;
 import org.eclipse.jdt.core.dom.ExpressionMethodReference;
 import org.eclipse.jdt.core.dom.IBinding;
@@ -645,6 +646,13 @@ protected int resolveLevel(MethodInvocation messageSend) {
 		return resolveLevelForNodeWithMethodBinding(messageSend, invocationBinding, initialReceiverType, false, false);
 	}
 
+	private List<Expression> arguments(ASTNode node) {
+		return (List<Expression>)
+				(node instanceof MethodInvocation method ? method.arguments() :
+				node instanceof ConstructorInvocation constr ? constr.arguments() :
+				null);
+	}
+
 	protected int resolveLevelForNodeWithMethodBinding(ASTNode messageSend,
 			IMethodBinding invocationBinding, ITypeBinding initialReceiverType,
 			boolean skipVerif, boolean nullParamsForSubTypeCheck) {
@@ -669,6 +677,16 @@ protected int resolveLevelForNodeWithMethodBinding(ASTNode messageSend,
 			invocationOrDeclarationBinding = declarationBinding;
 		}
 
+		if (invocationBinding.getParameterTypes().length == arguments(messageSend).size()) {
+			for (int i = 0; i < invocationBinding.getParameterTypes().length; i++) {
+				var source = arguments(messageSend).get(i).resolveTypeBinding();
+				var resolved = invocationBinding.getParameterTypes()[i];
+				if (source != null && !source.isAssignmentCompatible(resolved)) {
+					return INACCURATE_MATCH;
+				}
+			}
+		}
+
 		int invocOrDeclLevel = invocationLevel == IMPOSSIBLE_MATCH ? declarationLevel : invocationLevel;
 		// receiver type
 		if (this.pattern.declaringSimpleName == null && this.pattern.declaringQualification == null) {