Improve perf for some completion based on index

Don't read modifiers from file, get them from TypeNameMatch

Author: mickaelistria

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java

@@ -4094,10 +4094,18 @@ private boolean staticOnly() {
 	}
 
 	private CompletionProposal toProposal(TypeNameMatch typeNameMatch) {
-		return toProposal(typeNameMatch.getType(), typeNameMatch.getAccessibility());
+		return toProposal(typeNameMatch.getType(), typeNameMatch.getAccessibility(), typeNameMatch.getModifiers());
 	}
 
 	private CompletionProposal toProposal(IType type, int access) {
+		try {
+			return toProposal(type, access, type.getFlags());
+		} catch (JavaModelException ex) {
+			return toProposal(type, access, 0);
+		}
+	}
+
+	private CompletionProposal toProposal(IType type, int access, int modifiers) {
 		DOMInternalCompletionProposal res = createProposal(CompletionProposal.TYPE_REF);
 		char[] simpleName = type.getElementName().toCharArray();
 		char[] signature = SignatureUtils.createSignature(type).toCharArray();
@@ -4172,11 +4180,7 @@ private CompletionProposal toProposal(IType type, int access) {
 		} else {
 			res.setReplaceRange(this.toComplete.getStartPosition(), this.offset);
 		}
-		try {
-			res.setFlags(type.getFlags());
-		} catch (JavaModelException ex) {
-			ILog.get().error(ex.getMessage(), ex);
-		}
+		res.setFlags(modifiers);
 		if (this.toComplete instanceof SimpleName) {
 			res.setTokenRange(this.toComplete.getStartPosition(), this.toComplete.getStartPosition() + this.toComplete.getLength());
 		} else if (this.toComplete instanceof MarkerAnnotation) {