Fix potential NPE for recovered annotation types

Author: mickaelistria

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacAnnotationBinding.java

@@ -13,6 +13,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Objects;
+import java.util.Optional;
 import java.util.stream.Collectors;
 
 import org.eclipse.core.runtime.ILog;
@@ -62,27 +63,27 @@ public int getKind() {
 
 	@Override
 	public int getModifiers() {
-		return getAnnotationType().getModifiers();
+		return getAnnotationTypeOptional().map(ITypeBinding::getModifiers).orElse(0);
 	}
 
 	@Override
 	public boolean isDeprecated() {
-		return getAnnotationType().isDeprecated();
+		return getAnnotationTypeOptional().map(ITypeBinding::isDeprecated).orElse(false);
 	}
 
 	@Override
 	public boolean isRecovered() {
-		return getAnnotationType().isRecovered();
+		return getAnnotationTypeOptional().map(ITypeBinding::isRecovered).orElse(false);
 	}
 
 	@Override
 	public boolean isSynthetic() {
-		return getAnnotationType().isSynthetic();
+		return getAnnotationTypeOptional().map(ITypeBinding::isSynthetic).orElse(false);
 	}
 
 	@Override
 	public IJavaElement getJavaElement() {
-		return getAnnotationType().getJavaElement();
+		return getAnnotationTypeOptional().map(ITypeBinding::getJavaElement).orElse(null);
 	}
 
 	@Override
@@ -136,7 +137,7 @@ public IMemberValuePairBinding[] getDeclaredMemberValuePairs() {
 
 	@Override
 	public String getName() {
-		return getAnnotationType().getName();
+		return getAnnotationTypeOptional().map(ITypeBinding::getName).orElse(null);
 	}
 
 	@Override
@@ -149,4 +150,8 @@ public String toString() {
 	public IBinding getRecipient() {
 		return recipient;
 	}
+
+	private Optional<ITypeBinding> getAnnotationTypeOptional() {
+		return Optional.ofNullable(getAnnotationType());
+	}
 }