Try to add support for missing constructors

Signed-off-by: Rob Stryker <[email protected]>

Author: robstryker

org.eclipse.jdt.core.compiler.batch/.settings/org.eclipse.pde.api.tools.prefs

@@ -1,4 +1,4 @@
-#Fri May 21 10:24:07 EDT 2010
+ANNOTATION_ELEMENT_TYPE_ADDED_FIELD=Warning
 ANNOTATION_ELEMENT_TYPE_ADDED_METHOD_WITHOUT_DEFAULT_VALUE=Error
 ANNOTATION_ELEMENT_TYPE_CHANGED_TYPE_CONVERSION=Error
 ANNOTATION_ELEMENT_TYPE_REMOVED_FIELD=Error
@@ -8,6 +8,10 @@ API_COMPONENT_ELEMENT_TYPE_REMOVED_API_TYPE=Error
 API_COMPONENT_ELEMENT_TYPE_REMOVED_REEXPORTED_API_TYPE=Error
 API_COMPONENT_ELEMENT_TYPE_REMOVED_REEXPORTED_TYPE=Error
 API_COMPONENT_ELEMENT_TYPE_REMOVED_TYPE=Error
+API_USE_SCAN_FIELD_SEVERITY=Warning
+API_USE_SCAN_METHOD_SEVERITY=Warning
+API_USE_SCAN_TYPE_SEVERITY=Warning
+CLASS_ELEMENT_TYPE_ADDED_FIELD=Warning
 CLASS_ELEMENT_TYPE_ADDED_METHOD=Error
 CLASS_ELEMENT_TYPE_ADDED_RESTRICTIONS=Error
 CLASS_ELEMENT_TYPE_ADDED_TYPE_PARAMETER=Error
@@ -47,6 +51,7 @@ ILLEGAL_IMPLEMENT=Warning
 ILLEGAL_INSTANTIATE=Warning
 ILLEGAL_OVERRIDE=Warning
 ILLEGAL_REFERENCE=Warning
+INTERFACE_ELEMENT_TYPE_ADDED_DEFAULT_METHOD=Warning
 INTERFACE_ELEMENT_TYPE_ADDED_FIELD=Error
 INTERFACE_ELEMENT_TYPE_ADDED_METHOD=Error
 INTERFACE_ELEMENT_TYPE_ADDED_RESTRICTIONS=Error
@@ -58,6 +63,7 @@ INTERFACE_ELEMENT_TYPE_REMOVED_FIELD=Error
 INTERFACE_ELEMENT_TYPE_REMOVED_METHOD=Error
 INTERFACE_ELEMENT_TYPE_REMOVED_TYPE_MEMBER=Error
 INTERFACE_ELEMENT_TYPE_REMOVED_TYPE_PARAMETER=Error
+INVALID_ANNOTATION=Warning
 INVALID_JAVADOC_TAG=Warning
 INVALID_REFERENCE_IN_SYSTEM_LIBRARIES=Warning
 LEAK_EXTEND=Warning
@@ -83,12 +89,15 @@ TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_CLASS_BOUND=Error
 TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_INTERFACE_BOUND=Error
 UNUSED_PROBLEM_FILTERS=Warning
 automatically_removed_unused_problem_filters=false
+changed_execution_env=Warning
 eclipse.preferences.version=1
-incompatible_api_component_version=Error
+incompatible_api_component_version=Warning
 incompatible_api_component_version_include_major_without_breaking_change=Disabled
 incompatible_api_component_version_include_minor_without_api_change=Disabled
-invalid_since_tag_version=Error
-malformed_since_tag=Error
-missing_since_tag=Error
+incompatible_api_component_version_report_major_without_breaking_change=Warning
+incompatible_api_component_version_report_minor_without_api_change=Warning
+invalid_since_tag_version=Warning
+malformed_since_tag=Warning
+missing_since_tag=Warning
 report_api_breakage_when_major_version_incremented=Disabled
 report_resolution_errors_api_component=Warning

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/core/search/matching/DOMConstructorLocator.java

@@ -174,6 +174,28 @@ public LocatorResponse match(AbstractTypeDeclaration node, NodeSetWrapper nodeSe
 			&& matchesTypeReference(this.locator.pattern.declaringSimpleName, typeDecl.getSuperclassType())) {
 			return toResponse(POSSIBLE_MATCH);
 		}
+		if( this.locator.pattern instanceof ConstructorPattern cp ) {
+			MethodDeclaration constructor = (MethodDeclaration)node.bodyDeclarations().stream().
+					filter(x -> x instanceof MethodDeclaration md && md.isConstructor()).findAny().orElse(null);
+			if( constructor == null ) {
+				// We are searching for a constructor but this type doesn't have one
+				// Check it manually
+				// constructor name is stored in selector field
+				if (this.locator.pattern.declaringSimpleName != null &&
+						!this.locator.matchesName(this.locator.pattern.declaringSimpleName, node.getName().toString().toCharArray()))
+					return toResponse(IMPOSSIBLE_MATCH);
+
+				if (this.locator.pattern.parameterSimpleNames != null) {
+					int length = this.locator.pattern.parameterSimpleNames.length;
+					if( length > 0 ) return toResponse(IMPOSSIBLE_MATCH);
+				}
+
+				return toResponse(ACCURATE_MATCH);
+			}
+
+
+		}
+
 		return toResponse(IMPOSSIBLE_MATCH);
 	}