Skip to content

Commit 4c2f870

Browse files
mickaelistriarobstryker
authored andcommitted
Keep order for imports
Join filtering in the same iteration
1 parent bb0e480 commit 4c2f870

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacConverter.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,11 @@ void populateCompilationUnit(CompilationUnit res, JCCompilationUnit javacCompila
194194
if (javacCompilationUnit.getModule() != null && this.ast.apiLevel >= AST.JLS9_INTERNAL) {
195195
res.setModule(convert(javacCompilationUnit.getModuleDecl()));
196196
}
197-
javacCompilationUnit.getImports().stream().filter(imp -> imp instanceof JCImport).map(jc -> convert((JCImport)jc)).forEach(res.imports()::add);
198-
if (this.ast.apiLevel >= AST.JLS23_INTERNAL) {
199-
javacCompilationUnit.getImports().stream().filter(imp -> imp instanceof JCModuleImport).map(jc -> convert((JCModuleImport)jc)).forEach(res.imports()::add);
200-
}
197+
javacCompilationUnit.getImports().stream().map(tree ->
198+
tree instanceof JCImport imp ? convert(imp) :
199+
tree instanceof JCModuleImport moduleImp && this.ast.apiLevel >= AST.JLS23_INTERNAL ? convert(moduleImp) :
200+
null).filter(ImportDeclaration.class::isInstance)
201+
.forEach(res.imports()::add);
201202
javacCompilationUnit.getTypeDecls().stream()
202203
.map(n -> convertBodyDeclaration(n, res, false))
203204
.filter(Objects::nonNull)

0 commit comments

Comments
 (0)