Skip to content

Commit 637be14

Browse files
Rob Strykermickaelistria
authored andcommitted
Fixes 1145 - don't make a position when length is invalid
Signed-off-by: Rob Stryker <[email protected]>
1 parent 42f5279 commit 637be14

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/JavacProblemConverter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,9 @@ private org.eclipse.jface.text.Position getPositionByNodeRangeOnly(Diagnostic<?>
393393
JCCompilationUnit trackedUnit = this.units.get(jcDiagnostic.getSource());
394394
if (trackedUnit != null && trackedUnit.endPositions != null) {
395395
int endPosition = jcTree.getEndPosition(trackedUnit.endPositions);
396-
return new org.eclipse.jface.text.Position(startPosition, endPosition - startPosition);
396+
if( endPosition != -1 ) {
397+
return new org.eclipse.jface.text.Position(startPosition, endPosition - startPosition);
398+
}
397399
} else if (jcTree instanceof JCIdent ident) {
398400
return new org.eclipse.jface.text.Position(startPosition, ident.getName().length());
399401
}

0 commit comments

Comments
 (0)