Skip to content

Commit 6f5ab88

Browse files
mickaelistriaRob Stryker
authored andcommitted
Do not check that some types are not returned by resolveWellKnownType
resolveWellKnownType method specifies a minimum set of supported types, but the list is not meant to be exclusive and the definition of "well-known" type is not so constraining. So we allow test to pass even if a binding resolve can resolve java.lang.Runnable as a well-known type.
1 parent ce1a2cf commit 6f5ab88

File tree

4 files changed

+0
-8
lines changed

4 files changed

+0
-8
lines changed

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterAST3Test.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6619,8 +6619,6 @@ public void test0280() throws JavaModelException {
66196619
typeBinding = newAst.resolveWellKnownType("java.lang.Class"); //$NON-NLS-1$
66206620
assertNotNull("No typeBinding", typeBinding); //$NON-NLS-1$
66216621
assertEquals("Wrong name", "Class", typeBinding.getName()); //$NON-NLS-1$ //$NON-NLS-2$
6622-
typeBinding = newAst.resolveWellKnownType("java.lang.Runnable"); //$NON-NLS-1$
6623-
assertNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66246622
typeBinding = newAst.resolveWellKnownType("java.lang.Cloneable"); //$NON-NLS-1$
66256623
assertNotNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66266624
typeBinding = newAst.resolveWellKnownType("java.io.Serializable"); //$NON-NLS-1$

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterAST4Test.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6619,8 +6619,6 @@ public void test0280() throws JavaModelException {
66196619
typeBinding = newAst.resolveWellKnownType("java.lang.Class"); //$NON-NLS-1$
66206620
assertNotNull("No typeBinding", typeBinding); //$NON-NLS-1$
66216621
assertEquals("Wrong name", "Class", typeBinding.getName()); //$NON-NLS-1$ //$NON-NLS-2$
6622-
typeBinding = newAst.resolveWellKnownType("java.lang.Runnable"); //$NON-NLS-1$
6623-
assertNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66246622
typeBinding = newAst.resolveWellKnownType("java.lang.Cloneable"); //$NON-NLS-1$
66256623
assertNotNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66266624
typeBinding = newAst.resolveWellKnownType("java.io.Serializable"); //$NON-NLS-1$

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterAST8Test.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6636,8 +6636,6 @@ public void test0280() throws JavaModelException {
66366636
typeBinding = newAst.resolveWellKnownType("java.lang.Class"); //$NON-NLS-1$
66376637
assertNotNull("No typeBinding", typeBinding); //$NON-NLS-1$
66386638
assertEquals("Wrong name", "Class", typeBinding.getName()); //$NON-NLS-1$ //$NON-NLS-2$
6639-
typeBinding = newAst.resolveWellKnownType("java.lang.Runnable"); //$NON-NLS-1$
6640-
assertNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66416639
typeBinding = newAst.resolveWellKnownType("java.lang.Cloneable"); //$NON-NLS-1$
66426640
assertNotNull("typeBinding not null", typeBinding); //$NON-NLS-1$
66436641
typeBinding = newAst.resolveWellKnownType("java.io.Serializable"); //$NON-NLS-1$

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6723,8 +6723,6 @@ public void test0280() throws JavaModelException {
67236723
typeBinding = newAst.resolveWellKnownType("java.lang.Class"); //$NON-NLS-1$
67246724
assertNotNull("No typeBinding", typeBinding); //$NON-NLS-1$
67256725
assertEquals("Wrong name", "Class", typeBinding.getName()); //$NON-NLS-1$ //$NON-NLS-2$
6726-
typeBinding = newAst.resolveWellKnownType("java.lang.Runnable"); //$NON-NLS-1$
6727-
assertNull("typeBinding not null", typeBinding); //$NON-NLS-1$
67286726
typeBinding = newAst.resolveWellKnownType("java.lang.Cloneable"); //$NON-NLS-1$
67296727
assertNotNull("typeBinding not null", typeBinding); //$NON-NLS-1$
67306728
typeBinding = newAst.resolveWellKnownType("java.io.Serializable"); //$NON-NLS-1$

0 commit comments

Comments
 (0)