Prevent StackOverflowError with thrown type variables

Author: mickaelistria

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacMethodBinding.java

@@ -501,13 +501,17 @@ static void getKey(StringBuilder builder, MethodSymbol methodSymbol, ExecutableT
 			} else if (!(methodSymbol.getReturnType() instanceof JCNoType)) {
 				JavacTypeBinding.getKey(builder, methodSymbol.getReturnType(), false, true, true, resolver);
 			}
-			if (methodType != null) {
+			if (methodType != null && methodType.getThrownTypes() != null) {
 				methodType.getThrownTypes().stream()
 					.map(Type.class::cast)
-					.map(resolver.bindings::getTypeBinding)
-					.map(JavacTypeBinding::getKey)
-					.map(k -> "|" + k)  // key wants "|", signature wants "^"
-					.forEach(builder::append);
+					.forEach(param -> {
+						builder.append("|");  // key wants "|", signature wants "^"
+						try {
+							JavacTypeBinding.getKey(builder, param, false, true, true, resolver);
+						} catch (BindingKeyException ex) {
+							ILog.get().error(ex.getMessage(), ex);
+						}
+					});
 			}
 		}
 	}

org.eclipse.jdt.core.tests.javac/src/org/eclipse/jdt/core/tests/javac/JavacSpecificConverterTests.java

@@ -22,7 +22,9 @@
 import org.eclipse.jdt.core.dom.CompilationUnit;
 import org.eclipse.jdt.core.dom.FieldDeclaration;
 import org.eclipse.jdt.core.dom.Javadoc;
+import org.eclipse.jdt.core.dom.MethodDeclaration;
 import org.eclipse.jdt.core.dom.ModuleDeclaration;
+import org.eclipse.jdt.core.dom.NodeFinder;
 import org.eclipse.jdt.core.dom.TagElement;
 import org.eclipse.jdt.core.dom.TypeDeclaration;
 import org.junit.Test;
@@ -73,4 +75,22 @@ public boolean visit(ModuleDeclaration node) {
 			}
 		});
 	}
+
+	@Test
+	public void testInfiniteLoopParameterizedMethodKey() throws Exception {
+		ASTParser parser = ASTParser.newParser(AST.getJLSLatest());
+		String source = """
+				public class A {
+					public <E extends Exception> void m() throws E {
+					}
+				}
+				""";
+		parser.setSource(source.toCharArray());
+		parser.setUnitName("A.java");
+		parser.setEnvironment(null, null, null, true);
+		parser.setResolveBindings(true);
+		ASTNode node = parser.createAST(new NullProgressMonitor());
+		MethodDeclaration meth = (MethodDeclaration) NodeFinder.perform(node, source.indexOf("m()"), 0).getParent();
+		assertEquals("LA;.m<E:Ljava/lang/Exception;>()V|TE;", meth.resolveBinding().getKey());
+	}
 }