Fix StackOverflow in parameterized method binding key

Changes `JavaSearchBugs9Tests.testGH902_whenTypeReferenceIsUnknownButQualified_expectToBeFound`
and three other similar tests from an error to a failure.

- Fix recovered type binding implementations
  (some use recursion with no base case,
  some fail to consider that there's no type or symbol)
- Fix typevar tries to use method key in its key but method key uses typevar key
  - There's an existing to get around this, but it wasn't being used for
    some reason

Signed-off-by: David Thompson <[email protected]>

Author: datho7561

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacMethodBinding.java

@@ -474,7 +474,7 @@ static void getKey(StringBuilder builder, MethodSymbol methodSymbol, ExecutableT
 			if (methodType instanceof MethodType && !methodType.getTypeVariables().isEmpty()) { // parameterized
 				builder.append('<');
 				for (var typeParam : methodType.getTypeVariables()) {
-					JavacTypeBinding.getKey(builder, (Type)typeParam, false, true, useSlashes, resolver);
+					builder.append(JavacTypeVariableBinding.getTypeVariableKey((TypeVariableSymbol)typeParam.asElement(), resolver));
 				}
 				builder.append('>');
 			} else if (methodType instanceof ForAll && !methodType.getTypeVariables().isEmpty()) { // generic

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacRecoveredTypeBinding.java

@@ -31,7 +31,6 @@
 import org.eclipse.jdt.core.dom.SimpleName;
 import org.eclipse.jdt.core.dom.SimpleType;
 
-import com.sun.tools.javac.code.Type;
 import com.sun.tools.javac.code.Type.ArrayType;
 import com.sun.tools.javac.code.Type.PackageType;
 
@@ -73,24 +72,17 @@ public JavacTypeBinding getComponentType() {
 
 	@Override
 	public JavacTypeBinding getElementType() {
-		var res = getElementType();
-		if (res != null) {
-			return res;
+		if (this.type != null) {
+			return (JavacTypeBinding)super.getElementType();
 		}
-		if (isArray()) {
-			Type t = this.types.elemtype(this.type);
-			while (t instanceof Type.ArrayType) {
-				t = this.types.elemtype(t);
-			}
-			if (t == null || t.isErroneous()) {
-				if (this.domNode instanceof org.eclipse.jdt.core.dom.ArrayType domArrayType) {
-					return this.resolver.bindings.getRecoveredTypeBinding(t, domArrayType.getElementType());
-				} else {
-					return this.resolver.bindings.getRecoveredTypeBinding(t, domName());
-				}
+		if (this.domNode instanceof org.eclipse.jdt.core.dom.ArrayType domArrayType) {
+			org.eclipse.jdt.core.dom.Type cursor = domArrayType.getElementType();
+			while (cursor instanceof org.eclipse.jdt.core.dom.ArrayType at) {
+				cursor = at.getElementType();
 			}
+			return this.resolver.bindings.getRecoveredTypeBinding(this.type, cursor);
 		}
-		return res;
+		return null;
 	}
 
 	@Override
@@ -274,4 +266,38 @@ public String getKey() {
 		}
 		return "L" + getQualifiedName() + ";";
 	}
+	@Override
+	public String getKey(boolean includeTypeParameters, boolean useSlashes) {
+		if (this.type != null) {
+			return super.getKey(includeTypeParameters, useSlashes);
+		}
+		if (useSlashes) {
+			return "L" + getQualifiedName().replace('.', '/') + ";";
+		} else {
+			return "L" + getQualifiedName() + ";";
+		}
+	}
+	@Override
+	public String getGenericTypeSignature(boolean useSlashes) {
+		if (this.type == null) {
+			return getKey(false, useSlashes);
+		}
+		return super.getGenericTypeSignature(useSlashes);
+	}
+
+	@Override
+	public ITypeBinding[] getInterfaces() {
+		if (this.type != null) {
+			return super.getInterfaces();
+		}
+		return new ITypeBinding[0];
+	}
+
+	@Override
+	public ITypeBinding getSuperclass() {
+		if (this.type != null) {
+			return super.getSuperclass();
+		}
+		return null;
+	}
 }