Attempt skipping extra analysis when problems are not requested

Author: mickaelistria

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacCompilationUnitResolver.java

@@ -614,7 +614,7 @@ public void finished(TaskEvent e) {
 					problemConverter.registerUnit(e.getSourceFile(), u);
 				}
 
-				if (e.getKind() == TaskEvent.Kind.ANALYZE && Options.instance(context).isSet(Option.XLINT)) {
+				if (e.getKind() == TaskEvent.Kind.ANALYZE && Options.instance(context).get(Option.XLINT_CUSTOM).contains("all")) {
 					final JavaFileObject file = e.getSourceFile();
 					final CompilationUnit dom = filesToUnits.get(file);
 					if (dom == null) {
@@ -698,12 +698,10 @@ public Void visitClass(ClassTree node, Void p) {
 		JavacUtils.configureJavacContext(context, compilerOptions, javaProject, JavacUtils.isTest(javaProject, sourceUnits), ignoreModule);
 		Options javacOptions = Options.instance(context);
 		javacOptions.put("allowStringFolding", Boolean.FALSE.toString()); // we need to keep strings as authored
-		if ((focalPoint >= 0 || !resolveBindings) && (flags & ICompilationUnit.FORCE_PROBLEM_DETECTION) == 0) {
-			// most likely no need for linting
+		if (focalPoint >= 0 || (flags & ICompilationUnit.FORCE_PROBLEM_DETECTION) == 0) {
+			// most likely no need for more linting
 			// resolveBindings still seems requested for tests
-			javacOptions.remove(Option.XLINT.primaryName);
-			javacOptions.put(Option.XLINT_CUSTOM, "none");
-			javacOptions.remove(Option.XDOCLINT.primaryName);
+			javacOptions.put(Option.XLINT_CUSTOM, "raw");
 			javacOptions.put(Option.XDOCLINT_CUSTOM, "none");
 		}
 		javacOptions.put(Option.PROC, ProcessorConfig.isAnnotationProcessingEnabled(javaProject) ? "only" : "none");

org.eclipse.jdt.core.tests.javac/src/org/eclipse/jdt/core/tests/javac/CachingClassReaderTests.java

@@ -35,10 +35,57 @@
 import org.eclipse.jdt.core.dom.ASTParser;
 import org.eclipse.jdt.core.dom.CompilationUnit;
 import org.eclipse.jdt.core.dom.JavacCompilationUnitResolver;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class CachingClassReaderTests {
 
+	@Ignore // currently ignored https://github.com/eclipse-jdtls/eclipse-jdt-core-incubator/issues/1827
+	@Test
+	public void testInnerAnonymousWithTypeParams() throws Exception {
+		Path dir = Files.createTempDirectory(getClass().getName());
+		Path sourceFile = dir.resolve("A.java");
+		Files.write(sourceFile, """
+				class A<K, V> {
+					java.util.function.Function<K, V> m() {
+						return new java.util.function.Function<>() {
+							@Override
+							public V apply(K k) {
+								return null;
+							}
+						};
+					}
+				}
+				""".getBytes());
+		JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
+		StandardJavaFileManager fileManager = compiler.getStandardFileManager(null, null, null);
+		Iterable<? extends JavaFileObject> compilationUnits1 = fileManager.getJavaFileObjectsFromPaths(List.of(sourceFile));
+		CharArrayWriter writer = new CharArrayWriter(2000);
+		assertTrue(new String(writer.toCharArray()), compiler.getTask(writer, fileManager, null, List.of("--release", "17"), null, compilationUnits1).call());
+		Path Bclass = dir.resolve("A.class");
+		assertTrue(Files.exists(Bclass));
+
+		String source = """
+				class I {
+					A<String, String> a = new A<>();
+				}
+				""";
+		// What we really want to test is calling CachingClassSymbolClassReader multiple times for A$B
+		// but as we prefer avoiding references to internal Javac types in tests, we just load the AST multiple times.
+		for (int i = 0; i < 2; i++) {
+			ASTParser parser = ASTParser.newParser(AST.getJLSLatest());
+			parser.setSource(source.toCharArray());
+			parser.setUnitName("I.java");
+			parser.setEnvironment(new String[] { dir.toString() }, null, null, true);
+			parser.setResolveBindings(true);
+			try (var _ = withoutLoggedError()) {
+				var node = (CompilationUnit)parser.createAST(new NullProgressMonitor());
+				assertArrayEquals(new IProblem[0], node.getProblems());
+				node.getAST().resolveWellKnownType("A$1");
+			}
+		}
+	}
+
 	@Test
 	public void testIntersectionType() throws Exception {
 		Path dir = Files.createTempDirectory(getClass().getName());