Protected members from class in same package should be suggested

Fixes #1630 , fixes 1 test case

Signed-off-by: David Thompson <[email protected]>

Author: datho7561

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java

@@ -4337,9 +4337,13 @@ private void processMembers(ITypeBinding typeBinding, Bindings scope,
 					// check private
 					(!includePrivate && (binding.getModifiers() & Flags.AccPrivate) != 0)
 					// check protected
-					|| (!includeProtected && (binding.getModifiers() & Flags.AccProtected) != 0)
+					|| (!includeProtected && (binding.getModifiers() & Flags.AccProtected) != 0
+						&& !((typeBinding.getPackage() == null && originalPackageKey.isEmpty())
+							|| (typeBinding.getPackage() != null && originalPackageKey.equals(typeBinding.getPackage().getKey()))))
 					// check package private
-					|| ((binding.getModifiers() & (Flags.AccPublic | Flags.AccProtected | Flags.AccPrivate)) == 0 && !originalPackageKey.equals(typeBinding.getPackage().getKey()))
+					|| ((binding.getModifiers() & (Flags.AccPublic | Flags.AccProtected | Flags.AccPrivate)) == 0
+						&& !((typeBinding.getPackage() == null && originalPackageKey.isEmpty())
+							|| (typeBinding.getPackage() != null && originalPackageKey.equals(typeBinding.getPackage().getKey()))))
 					// check static
 					|| (isStaticContext && ((binding.getModifiers() & Flags.AccStatic) == 0 && !(binding instanceof ITypeBinding)))
 					// check abstract