Skip to content

Commit dfb6fad

Browse files
committed
Improve relevance calculation for NON_STATIC
Fixes 2 Javadoc-related test cases Signed-off-by: David Thompson <[email protected]>
1 parent 01dc9ae commit dfb6fad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4601,8 +4601,8 @@ private CompletionProposal toProposal(IBinding binding, String completion) {
46014601
relevance += (isInQualifiedName || res.getRequiredProposals() != null || inJavadoc ? 0 : RelevanceUtils.computeRelevanceForQualification(new String(res.getCompletion()).indexOf('.') >= 0, this.prefix, this.qualifiedPrefix));
46024602
relevance += RelevanceConstants.R_NON_RESTRICTED;
46034603
relevance += RelevanceUtils.computeRelevanceForInheritance(this.qualifyingType, binding);
4604-
relevance += ((isInQualifiedName && !staticOnly() && !Modifier.isStatic(binding.getModifiers())) || (inJavadoc && !res.isConstructor()) ? RelevanceConstants.R_NON_STATIC : 0) +
4605-
(binding instanceof IVariableBinding field && field.isEnumConstant() ? RelevanceConstants.R_ENUM + RelevanceConstants.R_ENUM_CONSTANT : 0);
4604+
relevance += !Modifier.isStatic(binding.getModifiers()) && ((isInQualifiedName && !staticOnly()) || (inJavadoc && !res.isConstructor())) ? RelevanceConstants.R_NON_STATIC : 0;
4605+
relevance += binding instanceof IVariableBinding field && field.isEnumConstant() ? RelevanceConstants.R_ENUM + RelevanceConstants.R_ENUM_CONSTANT : 0;
46064606
res.setRelevance(relevance);
46074607
if (res.getRequiredProposals() != null) {
46084608
for (CompletionProposal req : res.getRequiredProposals()) {

0 commit comments

Comments
 (0)