Ensure jdtls script helper functions always return a string path (#3179)

- Certain helper functions wrongly returned paths under certain conditions

Signed-off-by: Ahmed Yehia <[email protected]>

Author: Abstraxt-AA

org.eclipse.jdt.ls.product/scripts/jdtls.py

@@ -26,10 +26,10 @@ def get_java_executable(known_args):
 		java_executable = 'java'
 
 		if 'JAVA_HOME' in os.environ:
-			ext = '.exe' if platform.system()  == 'Windows' else ''
+			ext = '.exe' if platform.system() == 'Windows' else ''
 			java_exec_to_test = Path(os.environ['JAVA_HOME']) / 'bin' / f'java{ext}'
 			if java_exec_to_test.is_file():
-				java_executable = java_exec_to_test.resolve()
+				java_executable = str(java_exec_to_test.resolve())
 
 	if not known_args.validate_java_version:
 		return java_executable
@@ -51,7 +51,7 @@ def find_equinox_launcher(jdtls_base_directory):
 	plugins_dir = jdtls_base_directory / "plugins"
 	launchers = plugins_dir.glob('org.eclipse.equinox.launcher_*.jar')
 	for launcher in launchers:
-		return plugins_dir / launcher
+		return str(plugins_dir / launcher)
 
 	raise Exception("Cannot find equinox launcher")
 
@@ -67,7 +67,7 @@ def get_shared_config_path(jdtls_base_path):
 	else:
 		raise Exception("Unknown platform {} detected".format(system))
 
-	return jdtls_base_path / config_dir
+	return str(jdtls_base_path / config_dir)
 
 def main(args):
 	cwd_name = os.path.basename(os.getcwd())
@@ -82,7 +82,7 @@ def main(args):
 			action="append",
 			help="An additional JVM option (can be used multiple times. Note, use with equal sign. For example: --jvm-arg=-Dlog.level=ALL")
 	parser.add_argument("-data", default=jdtls_data_path)
-	
+
 	known_args, args = parser.parse_known_args(args)
 	java_executable = get_java_executable(known_args)
 
@@ -95,7 +95,7 @@ def main(args):
 			"-Dosgi.bundles.defaultStartLevel=4",
 			"-Declipse.product=org.eclipse.jdt.ls.core.product",
 			"-Dosgi.checkConfiguration=true",
-			"-Dosgi.sharedConfiguration.area=" + str(shared_config_path),
+			"-Dosgi.sharedConfiguration.area=" + shared_config_path,
 			"-Dosgi.sharedConfiguration.area.readOnly=true",
 			"-Dosgi.configuration.cascaded=true",
 			"-Xms1G",