Respect the autobuild setting on initialization. (#3177)

- Set autobuild setting for workspace as requested

Author: ethan-vanderheijden

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/LanguageServerApplication.java

@@ -22,19 +22,13 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 
-import org.eclipse.core.resources.IWorkspace;
-import org.eclipse.core.resources.IWorkspaceDescription;
 import org.eclipse.core.resources.IWorkspaceRoot;
 import org.eclipse.core.resources.ResourcesPlugin;
-import org.eclipse.core.runtime.CoreException;
-import org.eclipse.core.runtime.Platform;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.equinox.app.IApplication;
 import org.eclipse.equinox.app.IApplicationContext;
 import org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer;
 import org.eclipse.jdt.ls.core.internal.handlers.ProgressReporterManager;
-import org.osgi.framework.Bundle;
-import org.osgi.framework.BundleException;
 
 public class LanguageServerApplication implements IApplication {
 
@@ -49,7 +43,6 @@ public class LanguageServerApplication implements IApplication {
 
 	@Override
 	public Object start(IApplicationContext context) throws Exception {
-		prepareWorkspace();
 		prepareStreams();
 		JavaLanguageServerPlugin.startLanguageServer(this);
 		if (JavaLanguageServerPlugin.getInstance().getProtocol() instanceof JDTLanguageServer server) {
@@ -76,18 +69,6 @@ public Object start(IApplicationContext context) throws Exception {
 		return IApplication.EXIT_OK;
 	}
 
-	private static void prepareWorkspace() throws CoreException {
-		try {
-			Platform.getBundle(ResourcesPlugin.PI_RESOURCES).start(Bundle.START_TRANSIENT);
-			IWorkspace workspace = ResourcesPlugin.getWorkspace();
-			IWorkspaceDescription description = workspace.getDescription();
-			description.setAutoBuilding(false);
-			workspace.setDescription(description);
-		} catch (BundleException e) {
-			JavaLanguageServerPlugin.logException(e.getMessage(), e);
-		}
-	}
-
 	@Override
 	public void stop() {
 		synchronized (waitLock) {

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseInitHandler.java

@@ -113,6 +113,11 @@ public InitializeResult initialize(InitializeParams param) {
 			Preferences prefs = Preferences.createFrom((Map<String, Object>) settings);
 			prefs.setRootPaths(rootPaths);
 			preferenceManager.update(prefs);
+			try {
+				ProjectsManager.setAutoBuilding(preferenceManager.getPreferences().isAutobuildEnabled());
+			} catch (CoreException e) {
+				JavaLanguageServerPlugin.logException("Failed apply autobuilding setting", e);
+			}
 			if (!isWorkspaceInitialized()) {
 				// We don't care about triggering a full build here, like in onDidChangeConfiguration
 				try {