-
Notifications
You must be signed in to change notification settings - Fork 551
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
Component
None
Task description
Description
Related to #3406
ConfigMapIT is failing on windows with this error message:
Error: Errors:
Error: ConfigMapIT.k8sResource_whenRun_generatesK8sManifestsContainingConfigMap:37 � IllegalArgument Values not equal for entry: 'application.properties', expected 'environment = test
foo = bar' but was 'environment = test
foo = bar'
Error: ConfigMapIT.ocResource_whenRun_generatesOpenShiftManifestsContainingConfigMap:56 � IllegalArgument Values not equal for entry: 'application.properties', expected 'environment = test
foo = bar' but was 'environment = test
foo = bar'
This issue looks related to one issue I had fixed #3014
This issue looks similar to #3477 and #3478 but the code responsible for adding ConfigMap entries from file resides in fabric8 Kubernetes Client. Not sure whether to add handling for windows line breaks there or to add it in ConfigMapEnricher.
I think we need to debug here :
Lines 80 to 83 in 78e8631
| Path filePath = Paths.get(entry.getValue()); | |
| addEntriesFromDirOrFileToConfigMap(configMapBuilder, getOutput(key), filePath); | |
| it.remove(); | |
| } |
When I checked it I saw that configmap entries contain windows specific line breaks
Expected Behavior
ConfigMapIT passes on windows and Linux
Acceptance Criteria
- ConfigMapIT should pass on windows and Linux
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed