Skip to content
This repository was archived by the owner on Feb 12, 2019. It is now read-only.

Commit c407585

Browse files
committed
fixes tests
1 parent bcc3448 commit c407585

File tree

4 files changed

+19
-6
lines changed

4 files changed

+19
-6
lines changed

artemis-configuration/src/main/java/org/jnosql/artemis/configuration/DefaultConfigurationReader.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,12 @@ public <T> ConfigurationSettingsUnit read(ConfigurationUnit annotation, Class<T>
7070

7171
String name = configuration.getName();
7272
String description = configuration.getDescription();
73-
Map<String, Object> settings = new HashMap<>(ofNullable(configuration.getSettings()).orElse(emptyMap()));
74-
settings.putAll(System.getenv());
75-
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
73+
Map<String, Object> settings = getSettings(configuration);
7674
Class<?> provider = getProvider(configurationClass, configuration);
7775

7876
return new DefaultConfigurationSettingsUnit(name, description, provider, Settings.of(settings));
7977
}
8078

81-
8279
@Override
8380
public <T> ConfigurationSettingsUnit read(ConfigurationUnit annotation) {
8481

@@ -89,7 +86,7 @@ public <T> ConfigurationSettingsUnit read(ConfigurationUnit annotation) {
8986

9087
String name = configuration.getName();
9188
String description = configuration.getDescription();
92-
Map<String, Object> settings = new HashMap<>(ofNullable(configuration.getSettings()).orElse(emptyMap()));
89+
Map<String, Object> settings = getSettings(configuration);
9390

9491
return new DefaultConfigurationSettingsUnit(name, description, null, Settings.of(settings));
9592
}
@@ -107,6 +104,13 @@ private List<Configurable> getConfigurations(ConfigurationUnit annotation) {
107104
return select.get().read(stream, annotation);
108105
}
109106

107+
private Map<String, Object> getSettings(Configurable configuration) {
108+
Map<String, Object> settings = new HashMap<>(ofNullable(configuration.getSettings()).orElse(emptyMap()));
109+
settings.putAll(System.getenv());
110+
System.getProperties().forEach((k, v) -> settings.put(k.toString(), v));
111+
return settings;
112+
}
113+
110114
private String getExtension(ConfigurationUnit annotation) {
111115
String[] fileName = annotation.fileName().split("\\.");
112116
if (fileName.length != 2) {

artemis-configuration/src/test/java/org/jnosql/artemis/configuration/DefaultJSONConfigurationreaderTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ public void shouldReadAnnotationDefaultFile() {
5858
settings.put("key","value");
5959
settings.put("key2","value2");
6060
settings.put("key3","value3");
61+
settings.putAll(System.getenv());
62+
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
6163

6264
assertEquals("name-2", unit.getName().get());
6365
assertEquals("that is the description", unit.getDescription().get());
@@ -75,7 +77,8 @@ public void shouldReadConfiguration() {
7577
Map<String, Object> settings = new HashMap<>();
7678
settings.put("key","value");
7779
settings.put("key2","value2");
78-
80+
settings.putAll(System.getenv());
81+
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
7982
assertEquals("name", unit.getName().get());
8083
assertEquals("that is the description", unit.getDescription().get());
8184
assertEquals(Settings.of(settings), unit.getSettings());
@@ -93,6 +96,8 @@ public void shouldReadDefaultFile() {
9396
settings.put("key","value");
9497
settings.put("key2","value2");
9598
settings.put("key3","value3");
99+
settings.putAll(System.getenv());
100+
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
96101

97102
assertEquals("name-2", unit.getName().get());
98103
assertEquals("that is the description", unit.getDescription().get());

artemis-configuration/src/test/java/org/jnosql/artemis/configuration/DefaultXMLConfigurationReaderTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ public void shouldReadDefaultNameXML() {
4848
Map<String, Object> settings = new HashMap<>();
4949
settings.put("key","value");
5050
settings.put("key2","value2");
51+
settings.putAll(System.getenv());
52+
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
5153

5254
assertEquals("name", unit.getName().get());
5355
assertEquals("that is the description", unit.getDescription().get());

artemis-configuration/src/test/java/org/jnosql/artemis/configuration/DefaultYAMLConfigurationReaderTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ public void shouldReadDefaultNameYAML() {
4848
Map<String, Object> settings = new HashMap<>();
4949
settings.put("key","value");
5050
settings.put("key2","value2");
51+
settings.putAll(System.getenv());
52+
System.getProperties().forEach((k,v) -> settings.put(k.toString(), v));
5153

5254
assertEquals("name", unit.getName().get());
5355
assertEquals("that is the description", unit.getDescription().get());

0 commit comments

Comments
 (0)