Skip to content

Commit 0e90c2c

Browse files
committed
Merge branch 'master' of github.com:eclipse/jnosql-diana-driver
2 parents 52d1bd5 + 62e1c45 commit 0e90c2c

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

redis-driver/src/main/java/org/jnosql/diana/redis/key/RedisSet.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ class RedisSet<T> extends RedisCollection<T> implements Set<T> {
3131
@Override
3232
public boolean add(T e) {
3333
Objects.requireNonNull(e);
34-
jedis.sadd(keyWithNameSpace, JSONB.toJson(e));
35-
return false;
34+
if (isString) {
35+
jedis.sadd(keyWithNameSpace, e.toString());
36+
} else {
37+
jedis.sadd(keyWithNameSpace, JSONB.toJson(e));
38+
}
39+
return true;
3640
}
3741

3842
@Override
@@ -92,7 +96,7 @@ protected List<T> toArrayList() {
9296
Set<String> redisValues = jedis.smembers(keyWithNameSpace);
9397
List<T> list = new ArrayList<>();
9498
for (String redisValue : redisValues) {
95-
if(isString) {
99+
if (isString) {
96100
list.add((T) redisValue);
97101
} else {
98102
list.add(JSONB.fromJson(redisValue, clazz));

redis-driver/src/test/java/org/jnosql/diana/redis/key/RedisSetStringTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import java.util.Set;
2525

26+
import static org.junit.Assert.assertEquals;
2627
import static org.junit.Assert.assertTrue;
2728

2829
public class RedisSetStringTest {
@@ -44,6 +45,14 @@ public void shouldAddUsers() {
4445
users.add("otaviojava");
4546
assertTrue(users.size() == 1);
4647

48+
String user = users.iterator().next();
49+
assertEquals("otaviojava", user);
50+
}
51+
52+
@Test
53+
public void shouldRemoveSet() {
54+
assertTrue(users.isEmpty());
55+
users.add("otaviojava");
4756
users.remove("otaviojava");
4857
assertTrue(users.isEmpty());
4958
}

0 commit comments

Comments
 (0)