Skip to content

Commit 3852132

Browse files
committed
feat: make singleton at OracleNoSQLmanager
Signed-off-by: Otavio Santana <[email protected]>
1 parent af1c636 commit 3852132

File tree

7 files changed

+14
-7
lines changed

7 files changed

+14
-7
lines changed

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/communication/DefaultOracleNoSQLDocumentManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ private List<DocumentEntity> getIds(OracleQuery oracleQuery) {
236236

237237
@Override
238238
public void close() {
239-
239+
this.serviceHandle.close();
240240
}
241241

242242
@Override

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/communication/NoSQLHandleConfigConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package org.eclipse.jnosql.databases.oracle.communication;
1616

1717
import oracle.nosql.driver.NoSQLHandleConfig;
18-
import oracle.nosql.driver.NoSQLHandleFactory;
1918
import org.eclipse.jnosql.communication.Configurations;
2019
import org.eclipse.jnosql.communication.Settings;
2120

@@ -49,6 +48,6 @@ public NoSQLHandleConfiguration apply(Settings settings) {
4948
int waitMillis = settings.getOrDefault(OracleNoSQLConfigurations.TABLE_WAIT_MILLIS, DEFAULT_TABLE_WAIT_MILLIS);
5049
int delayMillis = settings.getOrDefault(OracleNoSQLConfigurations.TABLE_DELAY_MILLIS, DEFAULT_TABLE_DELAY_MILLIS);
5150
var tableLimits = new TableCreationConfiguration(readLimit, writeLimit, storageGB, waitMillis, delayMillis);
52-
return new NoSQLHandleConfiguration(NoSQLHandleFactory.createNoSQLHandle(config), tableLimits);
51+
return new NoSQLHandleConfiguration(config, tableLimits);
5352
}
5453
}

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/communication/NoSQLHandleConfiguration.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@
1515
package org.eclipse.jnosql.databases.oracle.communication;
1616

1717
import oracle.nosql.driver.NoSQLHandle;
18+
import oracle.nosql.driver.NoSQLHandleConfig;
19+
import oracle.nosql.driver.NoSQLHandleFactory;
20+
21+
record NoSQLHandleConfiguration(NoSQLHandleConfig config, TableCreationConfiguration tableCreationConfiguration) {
22+
23+
public NoSQLHandle serviceHandle() {
24+
return NoSQLHandleFactory.createNoSQLHandle(config);
25+
}
26+
1827

19-
record NoSQLHandleConfiguration(NoSQLHandle serviceHandle, TableCreationConfiguration tableCreationConfiguration) {
2028
}

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/communication/OracleDocumentManagerFactory.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public final class OracleDocumentManagerFactory implements DocumentManagerFactor
3535

3636
@Override
3737
public void close() {
38-
this.configuration.serviceHandle().close();
3938
}
4039

4140
@Override

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/communication/OracleNoSQLBucketManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public <K> void delete(Iterable<K> keys) {
136136

137137
@Override
138138
public void close() {
139-
139+
this.serviceHandle.close();
140140
}
141141

142142
private <K, V> void putImplementation(K key, V value) {

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/mapping/DocumentManagerSupplier.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class DocumentManagerSupplier implements Supplier<OracleNoSQLDocumentManager> {
3737
@Override
3838
@Produces
3939
@Typed(OracleNoSQLDocumentManager.class)
40+
@ApplicationScoped
4041
public OracleNoSQLDocumentManager get() {
4142
Settings settings = MicroProfileSettings.INSTANCE;
4243
OracleDocumentConfiguration configuration = new OracleDocumentConfiguration();

jnosql-nosql-oracle/src/main/java/org/eclipse/jnosql/databases/oracle/mapping/OracleExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void onAfterBeanDiscovery(@Observes final AfterBeanDiscovery afterBeanDiscovery)
3333

3434
LOGGER.info("Starting the onAfterBeanDiscovery with elements number: " + crudTypes.size());
3535

36-
crudTypes.forEach(type -> afterBeanDiscovery.addBean(new OracleRepositoryBean(type)));
36+
crudTypes.forEach(type -> afterBeanDiscovery.addBean(new OracleRepositoryBean<>(type)));
3737

3838
LOGGER.info("Finished the onAfterBeanDiscovery");
3939
}

0 commit comments

Comments
 (0)